Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Issue 2519103002: SVGRoot's writing-mode should not affect SVGText/SVGForeign's location (Closed)

Created:
4 years, 1 month ago by Xianzhu
Modified:
4 years, 1 month ago
Reviewers:
pdr.
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SVGRoot's writing-mode should not affect SVGText/SVGForeign's location BUG=667124 Committed: https://crrev.com/493c1af179be82c3163b37a219ddcdf3c1eb703e Cr-Commit-Position: refs/heads/master@{#433612}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Xianzhu
4 years, 1 month ago (2016-11-21 17:53:33 UTC) #4
pdr.
On 2016/11/21 at 17:53:33, wangxianzhu wrote: > LGTM
4 years, 1 month ago (2016-11-21 19:20:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519103002/1
4 years, 1 month ago (2016-11-21 19:43:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 19:52:13 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 19:55:19 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/493c1af179be82c3163b37a219ddcdf3c1eb703e
Cr-Commit-Position: refs/heads/master@{#433612}

Powered by Google App Engine
This is Rietveld 408576698