Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2519103002: SVGRoot's writing-mode should not affect SVGText/SVGForeign's location (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index c8fa313b17779d9aa155ee519dd6f282b9aba046..3bb85b57f829de62d28bb7af3e616142577908f7 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -5177,6 +5177,11 @@ LayoutPoint LayoutBox::flipForWritingModeForChild(
}
LayoutBox* LayoutBox::locationContainer() const {
+ // Location of a non-root SVG object derived from LayoutBox should not be
+ // affected by writing-mode of the containing box (SVGRoot).
+ if (isSVG() && !isSVGRoot())
+ return nullptr;
+
// Normally the box's location is relative to its containing box.
LayoutObject* container = this->container();
while (container && !container->isBox())
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698