Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2519083002: Revert "Revert "Change call-sites now that SkCanvas is not ref-counted"" (Closed)

Created:
4 years, 1 month ago by reed1
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, blink-reviews-platform-graphics_chromium.org, dshwang, fs, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, kouhei+svg_chromium.org, shaktisahu+watch-blimp_chromium.org, pdr+svgwatchlist_chromium.org, krit, maniscalco+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, jam, gcasto+watch-blimp_chromium.org, Justin Novosad, jbauman+watch_chromium.org, marcinjb+watch-blimp_chromium.org, Rik, einbinder+watch-test-runner_chromium.org, khushalsagar+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, blink-reviews, kalyank, rwlbuis, ajuma+watch_chromium.org, scf+watch-blimp_chromium.org, mlamouri+watch-content_chromium.org, mac-reviews_chromium.org, jbroman, pdr+graphicswatchlist_chromium.org, gyuyoung2, piman+watch_chromium.org, cc-bugs_chromium.org, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, Ian Vollick, tfarina, steimel+watch-blimp_chromium.org, android-webview-reviews_chromium.org, perumaal+watch-blimp_chromium.org, drott+blinkwatch_chromium.org, f(malita), darin-cc_chromium.org, danakj+watch_chromium.org, dtrainor+watch-blimp_chromium.org, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Revert "Change call-sites now that SkCanvas is not ref-counted"" Change since first commit: rebase on top of changes to pepper that eliminated the need for SkCanvas to be reference counted. This reverts commit c5afa233cc6b4eff679a2e6fbac926567ac5bf17. https://codereview.chromium.org/2509983004 BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR= Committed: https://crrev.com/e27fa89ee10d287ece8b775864fa609e3a78e062 Cr-Commit-Position: refs/heads/master@{#433625}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -193 lines) Patch
M android_webview/native/java_browser_view_renderer_helper.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M blimp/test/support/compositor/picture_cache_test_support.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/blimp/compositor_state_deserializer_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/blimp/picture_data_conversions_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M cc/output/software_renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/software_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/playback/discardable_image_map.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/playback/discardable_image_map.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/playback/display_item_list_unittest.cc View 14 chunks +17 lines, -28 lines 0 comments Download
M cc/raster/gpu_raster_buffer_provider.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/fake_content_layer_client.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M cc/test/solid_color_content_layer_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_masks.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_tiles.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/compositor/layer/crushed_sprite_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/compositor/layer/crushed_sprite_layer.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M components/test_runner/pixel_dump.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/compositor/software_output_device_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/software_output_device_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/compositor/software_output_device_win.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/software_output_device_win.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/renderer/pepper/ppb_image_data_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/ppb_image_data_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_image_data_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_image_data_proxy.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M skia/config/SkUserConfig.h View 1 chunk +0 lines, -4 lines 0 comments Download
M skia/ext/analysis_canvas_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/bitmap_platform_device_cairo.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M skia/ext/bitmap_platform_device_mac.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M skia/ext/bitmap_platform_device_mac_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M skia/ext/bitmap_platform_device_skia.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M skia/ext/bitmap_platform_device_win.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M skia/ext/platform_canvas.h View 1 chunk +46 lines, -42 lines 0 comments Download
M skia/ext/platform_canvas.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M skia/ext/platform_canvas_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M skia/ext/skia_utils_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImageTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/paint_recorder.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/gfx/blit_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/canvas.h View 3 chunks +10 lines, -3 lines 0 comments Download
M ui/gfx/canvas.cc View 3 chunks +12 lines, -9 lines 0 comments Download
M ui/gfx/render_text_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/surface/transport_dib.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/surface/transport_dib_posix.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/surface/transport_dib_win.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/views/border_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (13 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519083002/20001
4 years, 1 month ago (2016-11-21 20:16:02 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-21 20:23:25 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 20:26:06 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e27fa89ee10d287ece8b775864fa609e3a78e062
Cr-Commit-Position: refs/heads/master@{#433625}

Powered by Google App Engine
This is Rietveld 408576698