Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2519073002: Revert of [counters] RuntimeStats: fix wrong bookkeeping when dynamically changing counters. (Closed)

Created:
4 years, 1 month ago by Camillo Bruni
Modified:
4 years, 1 month ago
Reviewers:
Igor Sheludko
CC:
lpy, v8-reviews_googlegroups.com, fmeawad
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [counters] RuntimeStats: fix wrong bookkeeping when dynamically changing counters. (patchset #10 id:180001 of https://codereview.chromium.org/2511093002/ ) Reason for revert: Wronged it even more. Original issue's description: > [counters] RuntimeStats: fix wrong bookkeeping when dynamically changing counters > > RuntimeTimerScopes always subtract their own time from the parent timer's > counter to properly account for the own time. Once a scope is destructed it > adds it own timer to the current active counter. However, if the current > counter is changed with CorrectCurrentCounterId we will attribute all the > subtimers to the previous counter, and add the own time to the new counter. > This way it is possible to end up with negative times in certain counters but > the overall would still be correct. > > BUG= > > Committed: https://crrev.com/f6c74d964d9387df4bed3d8c1ded51eb9e8aa6e8 > Cr-Commit-Position: refs/heads/master@{#41142} TBR=ishell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/10a31136c4dc61f8ea227bd63e580538352a82a1 Cr-Commit-Position: refs/heads/master@{#41150}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -338 lines) Patch
M src/base/platform/elapsed-timer.h View 3 chunks +5 lines, -14 lines 0 comments Download
M src/counters.h View 5 chunks +62 lines, -39 lines 0 comments Download
M src/counters.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/counters-inl.h View 1 chunk +0 lines, -47 lines 0 comments Download
M test/unittests/counters-unittest.cc View 3 chunks +0 lines, -237 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Camillo Bruni
Created Revert of [counters] RuntimeStats: fix wrong bookkeeping when dynamically changing counters.
4 years, 1 month ago (2016-11-21 16:00:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519073002/1
4 years, 1 month ago (2016-11-21 16:00:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 16:00:36 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 16:01:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10a31136c4dc61f8ea227bd63e580538352a82a1
Cr-Commit-Position: refs/heads/master@{#41150}

Powered by Google App Engine
This is Rietveld 408576698