Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3617)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

Issue 2519053002: 📰 Let the backend trigger sign in related refreshes (Closed)
Patch Set: Fix iOS build Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java
index a8bf6110228487d42c74c36f326bc585f95af4d0..25461ced3f15a9037e3fd6f50616125f61d9a4fe 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java
@@ -42,13 +42,13 @@
@Nullable
private final SigninObserver mObserver;
- public SignInPromo(NodeParent parent, NewTabPageAdapter adapter) {
+ public SignInPromo(NodeParent parent) {
super(parent);
mDismissed = ChromePreferenceManager.getInstance(ContextUtils.getApplicationContext())
.getNewTabPageSigninPromoDismissed();
final SigninManager signinManager = SigninManager.get(ContextUtils.getApplicationContext());
- mObserver = mDismissed ? null : new SigninObserver(signinManager, adapter);
+ mObserver = mDismissed ? null : new SigninObserver(signinManager);
setVisible(signinManager.isSignInAllowed() && !signinManager.isSignedInOnNative());
}
@@ -122,14 +122,12 @@ public void dismiss() {
class SigninObserver
implements SignInStateObserver, SignInAllowedObserver, DestructionObserver {
private final SigninManager mSigninManager;
- private final NewTabPageAdapter mAdapter;
/** Guards {@link #unregister()}, which can be called multiple times. */
private boolean mUnregistered;
- private SigninObserver(SigninManager signinManager, NewTabPageAdapter adapter) {
+ private SigninObserver(SigninManager signinManager) {
mSigninManager = signinManager;
- mAdapter = adapter;
mSigninManager.addSignInAllowedObserver(this);
mSigninManager.addSignInStateObserver(this);
}
@@ -158,7 +156,6 @@ public void onSignInAllowedChanged() {
@Override
public void onSignedIn() {
setVisible(false);
- mAdapter.resetSections(/*alwaysAllowEmptySections=*/false);
}
@Override

Powered by Google App Engine
This is Rietveld 408576698