Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

Issue 2519053002: 📰 Let the backend trigger sign in related refreshes (Closed)
Patch Set: Fix iOS build Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
index 00a3a2ebca0a7d4a4b470a9af769b5339a4650d0..f9ff44e5560c7fd4907dc4ff8127b7bc4b40a16a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
@@ -170,7 +170,7 @@ public void onItemRangeRemoved(TreeNode child, int index, int count) {
}
};
- mSigninPromo = new SignInPromo(mRoot, this);
+ mSigninPromo = new SignInPromo(mRoot);
mAllDismissed = new AllDismissedItem(mRoot);
mFooter = new Footer(mRoot);
DestructionObserver signInObserver = mSigninPromo.getObserver();
@@ -299,9 +299,7 @@ public void onCategoryStatusChanged(@CategoryInt int category, @CategoryStatusEn
return;
case CategoryStatus.SIGNED_OUT:
- resetSection(category, status, /*alwaysAllowEmptySections=*/false);
- return;
-
+ // TODO(dgn): We currently can only reach this through an old variation parameter.
default:
mSections.get(category).setStatus(status);
return;
@@ -315,6 +313,11 @@ public void onSuggestionInvalidated(@CategoryInt int category, String idWithinCa
}
@Override
+ public void onFullRefreshRequired() {
+ resetSections(/*alwaysAllowEmptySections=*/false);
+ }
+
+ @Override
@ItemViewType
public int getItemViewType(int position) {
return mRoot.getItemViewType(position);
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698