Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 2518963004: Fix button-pressed handling in ImeDetailedView (Closed)

Created:
4 years, 1 month ago by tdanderson
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Fix button-pressed handling in ImeDetailedView ImeDetailedView::HandleButtonPressed() now calls up to its superclass ImeListView::HandleButtonPressed() in order to handle clicks on the VK toggle button. BUG=657146 TEST=ash_unittests Review-Url: https://codereview.chromium.org/2513713002 Cr-Commit-Position: refs/heads/master@{#433076} (cherry picked from commit 6a7e15b52db3937158cbeee847dbbc822c1b7e77) Committed: https://chromium.googlesource.com/chromium/src/+/fe09ab9cb920072e24c817158190a44efec706d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M ash/common/system/chromeos/ime_menu/ime_list_view.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M ash/common/system/ime/tray_ime_chromeos.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tdanderson
4 years, 1 month ago (2016-11-22 01:49:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fe09ab9cb920072e24c817158190a44efec706d9.

Powered by Google App Engine
This is Rietveld 408576698