Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Issue 2513713002: Fix button-pressed handling in ImeDetailedView (Closed)

Created:
4 years, 1 month ago by tdanderson
Modified:
4 years, 1 month ago
Reviewers:
varkha
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix button-pressed handling in ImeDetailedView ImeDetailedView::HandleButtonPressed() now calls up to its superclass ImeListView::HandleButtonPressed() in order to handle clicks on the VK toggle button. BUG=657146 TEST=ash_unittests Committed: https://crrev.com/6a7e15b52db3937158cbeee847dbbc822c1b7e77 Cr-Commit-Position: refs/heads/master@{#433076}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M ash/common/system/chromeos/ime_menu/ime_list_view.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M ash/common/system/ime/tray_ime_chromeos.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tdanderson
Valery, can you please take a look?
4 years, 1 month ago (2016-11-17 20:50:30 UTC) #3
varkha
lgtm
4 years, 1 month ago (2016-11-18 02:32:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513713002/1
4 years, 1 month ago (2016-11-18 02:36:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 03:50:26 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 03:54:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a7e15b52db3937158cbeee847dbbc822c1b7e77
Cr-Commit-Position: refs/heads/master@{#433076}

Powered by Google App Engine
This is Rietveld 408576698