Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: chrome/browser/android/search_geolocation_disclosure_tab_helper.h

Issue 2518963002: Record metric of geo permission before and after showing the disclosure. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/search_geolocation_disclosure_tab_helper.h
diff --git a/chrome/browser/android/search_geolocation_disclosure_tab_helper.h b/chrome/browser/android/search_geolocation_disclosure_tab_helper.h
index b121eddeba2ce87250117e70a00bc40375036910..fec651d6ae7d958568f364eb79a1b2bb886c3410 100644
--- a/chrome/browser/android/search_geolocation_disclosure_tab_helper.h
+++ b/chrome/browser/android/search_geolocation_disclosure_tab_helper.h
@@ -36,6 +36,8 @@ class SearchGeolocationDisclosureTabHelper
SearchGeolocationDisclosureTabHelper>;
void MaybeShowDefaultSearchGeolocationDisclosure(GURL gurl);
+ void RecordPreDisclosureMetrics(GURL gurl);
raymes 2016/11/22 01:54:00 nit: consider adding comments for these. In partic
raymes 2016/11/22 01:54:00 nit: const GURL& gurl (may want to update the one
benwells 2016/11/22 02:23:07 Done.
benwells 2016/11/22 02:23:07 Done.
+ void RecordPostDisclosureMetrics(GURL gurl);
Profile* GetProfile();
bool consistent_geolocation_enabled_;

Powered by Google App Engine
This is Rietveld 408576698