chrome/browser/android/search_geolocation_disclosure_tab_helper.h - Issue 2518963002: Record metric of geo permission before and after showing the disclosure.

Side by Side Diff: chrome/browser/android/search_geolocation_disclosure_tab_helper.h

Issue 2518963002: Record metric of geo permission before and after showing the disclosure. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « no previous file | chrome/browser/android/search_geolocation_disclosure_tab_helper.cc » ('j') | chrome/browser/android/search_geolocation_disclosure_tab_helper.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_ANDROID_SEARCH_GEOLOCATION_DISCLOSURE_TAB_HELPER_H_	5 #ifndef CHROME_BROWSER_ANDROID_SEARCH_GEOLOCATION_DISCLOSURE_TAB_HELPER_H_

6 #define CHROME_BROWSER_ANDROID_SEARCH_GEOLOCATION_DISCLOSURE_TAB_HELPER_H_	6 #define CHROME_BROWSER_ANDROID_SEARCH_GEOLOCATION_DISCLOSURE_TAB_HELPER_H_

7	7

8 #include "base/macros.h"	8 #include "base/macros.h"

9 #include "content/public/browser/web_contents_observer.h"	9 #include "content/public/browser/web_contents_observer.h"

10 #include "content/public/browser/web_contents_user_data.h"	10 #include "content/public/browser/web_contents_user_data.h"

(...skipping 18 matching lines...) Expand all Loading...
29 const content::LoadCommittedDetails& load_details) override;	29 const content::LoadCommittedDetails& load_details) override;

30	30

31 static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);	31 static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);

32	32

33 private:	33 private:

34 explicit SearchGeolocationDisclosureTabHelper(content::WebContents* contents);	34 explicit SearchGeolocationDisclosureTabHelper(content::WebContents* contents);

35 friend class content::WebContentsUserData<	35 friend class content::WebContentsUserData<

36 SearchGeolocationDisclosureTabHelper>;	36 SearchGeolocationDisclosureTabHelper>;

37	37

38 void MaybeShowDefaultSearchGeolocationDisclosure(GURL gurl);	38 void MaybeShowDefaultSearchGeolocationDisclosure(GURL gurl);

	39 void RecordPreDisclosureMetrics(GURL gurl);
	raymes 2016/11/22 01:54:00 nit: consider adding comments for these. In partic nit: consider adding comments for these. In particular I missed the fact that it would only be recorded once per client. raymes 2016/11/22 01:54:00 nit: const GURL& gurl (may want to update the one nit: const GURL& gurl (may want to update the one above too if you like) benwells 2016/11/22 02:23:07 Done. Show quoted text On 2016/11/22 01:54:00, raymes wrote: > nit: const GURL& gurl (may want to update the one above too if you like) Done. benwells 2016/11/22 02:23:07 Done. Show quoted text On 2016/11/22 01:54:00, raymes wrote: > nit: consider adding comments for these. In particular I missed the fact that it > would only be recorded once per client. Done.
	40 void RecordPostDisclosureMetrics(GURL gurl);

39 Profile* GetProfile();	41 Profile* GetProfile();

40	42

41 bool consistent_geolocation_enabled_;	43 bool consistent_geolocation_enabled_;

42	44

43 DISALLOW_COPY_AND_ASSIGN(SearchGeolocationDisclosureTabHelper);	45 DISALLOW_COPY_AND_ASSIGN(SearchGeolocationDisclosureTabHelper);

44 };	46 };

45	47

46 #endif // CHROME_BROWSER_ANDROID_SEARCH_GEOLOCATION_DISCLOSURE_TAB_HELPER_H_	48 #endif // CHROME_BROWSER_ANDROID_SEARCH_GEOLOCATION_DISCLOSURE_TAB_HELPER_H_

OLD	NEW