Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7445)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/usb/usb_chooser_controller.cc

Issue 2518933004: Add multiple selection support to chooser on desktops (Closed)
Patch Set: address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/bluetooth/bluetooth_chooser_controller_unittest.cc ('K') | « chrome/browser/usb/usb_chooser_controller.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/usb/usb_chooser_controller.cc
diff --git a/chrome/browser/usb/usb_chooser_controller.cc b/chrome/browser/usb/usb_chooser_controller.cc
index 2075f5917721d523420856394cd1eb1e72aa4136..500b4830be65203180594ea630a329a4d6f64fed 100644
--- a/chrome/browser/usb/usb_chooser_controller.cc
+++ b/chrome/browser/usb/usb_chooser_controller.cc
@@ -109,7 +109,9 @@ base::string16 UsbChooserController::GetStatus() const {
return base::string16();
}
-void UsbChooserController::Select(size_t index) {
+void UsbChooserController::Select(const std::vector<size_t>& indices) {
+ DCHECK(indices.size() == 1);
Reilly Grant (use Gerrit) 2016/11/22 20:55:27 DCHECK_EQ(indices.size(), 1)
juncai 2016/11/22 23:12:06 Done.
+ size_t index = indices[0];
DCHECK_LT(index, devices_.size());
content::WebContents* web_contents =
content::WebContents::FromRenderFrameHost(render_frame_host_);
« chrome/browser/ui/bluetooth/bluetooth_chooser_controller_unittest.cc ('K') | « chrome/browser/usb/usb_chooser_controller.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698