chrome/browser/ui/bluetooth/bluetooth_chooser_controller_unittest.cc - Issue 2518933004: Add multiple selection support to chooser on desktops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/bluetooth/bluetooth_chooser_controller_unittest.cc

Issue 2518933004: Add multiple selection support to chooser on desktops (Closed)

Patch Set: address comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc ('K') | « chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc ('k') | chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm » ('j') | chrome/browser/usb/usb_chooser_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/bluetooth/bluetooth_chooser_controller_unittest.cc

diff --git a/chrome/browser/ui/bluetooth/bluetooth_chooser_controller_unittest.cc b/chrome/browser/ui/bluetooth/bluetooth_chooser_controller_unittest.cc

index 414ac09573b2c4f2b3a1d513af451545cd2304f5..27e4671d827e02398b121f5244e72467cb61b1b3 100644

--- a/chrome/browser/ui/bluetooth/bluetooth_chooser_controller_unittest.cc

+++ b/chrome/browser/ui/bluetooth/bluetooth_chooser_controller_unittest.cc

@@ -351,7 +351,9 @@ TEST_F(BluetoothChooserControllerWithDevicesAddedTest, RefreshOptions) {

TEST_F(BluetoothChooserControllerWithDevicesAddedTest,

SelectingOneDeviceShouldCallEventHandler) {

- bluetooth_chooser_controller_.Select(0);

+ std::vector<size_t> indices;

+ indices.push_back(0);

Reilly Grant (use Gerrit) 2016/11/22 20:55:27 std::vector<size_t> indices{1};

juncai 2016/11/22 23:12:06 Done.

+ bluetooth_chooser_controller_.Select(indices);

EXPECT_EQ(content::BluetoothChooser::Event::SELECTED, last_event_);

EXPECT_EQ("id_a", last_device_id_);

}