Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2518783002: [ios] Removed -[CRWSessionController goDelta:]. (Closed)

Created:
4 years, 1 month ago by Eugene But (OOO till 7-30)
Modified:
4 years, 1 month ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removed -[CRWSessionController goDelta:]. BUG=661316 Committed: https://crrev.com/a73497b8a3418e83a709ac5cf18132bfd2719924 Cr-Commit-Position: refs/heads/master@{#433615}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -9 lines) Patch
M ios/web/navigation/crw_session_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/web/navigation/crw_session_controller.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl.mm View 1 chunk +2 lines, -1 line 0 comments Download
M ios/web/navigation/navigation_manager_impl_unittest.mm View 1 chunk +115 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Eugene But (OOO till 7-30)
4 years, 1 month ago (2016-11-19 02:38:40 UTC) #2
kkhorimoto
lgtm
4 years, 1 month ago (2016-11-21 19:37:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518783002/1
4 years, 1 month ago (2016-11-21 19:48:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 20:00:14 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 20:03:18 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a73497b8a3418e83a709ac5cf18132bfd2719924
Cr-Commit-Position: refs/heads/master@{#433615}

Powered by Google App Engine
This is Rietveld 408576698