ios/web/navigation/navigation_manager_impl.mm - Issue 2518783002: [ios] Removed -[CRWSessionController goDelta:].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/navigation/navigation_manager_impl.mm

Issue 2518783002: [ios] Removed -[CRWSessionController goDelta:]. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/navigation/navigation_manager_impl.mm

diff --git a/ios/web/navigation/navigation_manager_impl.mm b/ios/web/navigation/navigation_manager_impl.mm

index 3c76b2b37aab65b2a06a26d052a2984c037f4a25..172dd450961cc1121b104ad30bbe3024d9677b2c 100644

--- a/ios/web/navigation/navigation_manager_impl.mm

+++ b/ios/web/navigation/navigation_manager_impl.mm

@@ -295,7 +295,8 @@ bool NavigationManagerImpl::CanGoForward() const {

}

bool NavigationManagerImpl::CanGoToOffset(int offset) const {

- return [session_controller_ canGoDelta:offset];

+ int index = GetIndexForOffset(offset);

+ return 0 <= index && index < GetItemCount();

}

void NavigationManagerImpl::GoBack() {