Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2518693002: Skip tests on Precise that were marked NeedsRebaseline for Precise. (Closed)

Created:
4 years, 1 month ago by qyearsley
Modified:
4 years, 1 month ago
Reviewers:
tkent, Dirk Pranke
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip tests on Precise that were marked NeedsRebaseline for Precise. Background: In the past few days, rebaseline-o-matic has been re-adding lines to TestExpectations with the [ Precise ] specifier, likely because the WebKit Linux Precise builder was removed but the linux-precise port isn't yet removed, and the builder WebKit Linux Precise was not yet removed from from webkitpy/config/builders.py. This is happening because we're dropping support for Linux Precise (http://crbug.com/660580). Now, webkitpy/config/builders.py has been updated, and the precise port should be removed next week; after that happens, all of these lines can be removed from TestExpectations. BUG=666901

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -21 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 5 chunks +18 lines, -21 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
qyearsley
4 years, 1 month ago (2016-11-18 22:25:43 UTC) #3
Dirk Pranke
lgtm
4 years, 1 month ago (2016-11-18 22:40:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518693002/1
4 years, 1 month ago (2016-11-18 22:51:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/335344)
4 years, 1 month ago (2016-11-19 00:52:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518693002/1
4 years, 1 month ago (2016-11-19 03:17:08 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/335573)
4 years, 1 month ago (2016-11-19 03:24:14 UTC) #12
Dirk Pranke
4 years, 1 month ago (2016-11-19 04:43:05 UTC) #13
I'm going to take this over and merge it forward so we can hopefully get r-o-m
to be happy again. See https://codereview.chromium.org/2515573004.

Powered by Google App Engine
This is Rietveld 408576698