Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2515573004: Skip tests on Precise that were marked NeedsRebaseline for Precise. (Closed)

Created:
4 years, 1 month ago by Dirk Pranke
Modified:
4 years, 1 month ago
Reviewers:
tkent, qyearsley
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip tests on Precise that were marked NeedsRebaseline for Precise. Background: In the past few days, rebaseline-o-matic has been re-adding lines to TestExpectations with the [ Precise ] specifier, likely because the WebKit Linux Precise builder was removed but the linux-precise port isn't yet removed, and the builder WebKit Linux Precise was not yet removed from from webkitpy/config/builders.py. This is happening because we're dropping support for Linux Precise (http://crbug.com/660580). Now, webkitpy/config/builders.py has been updated, and the precise port should be removed next week; after that happens, all of these lines can be removed from TestExpectations. (Patch from https://codereview.chromium.org/2518693002/#ps1, merged forward). TBR=qyearsley@chromium.org, tkent@chromium.rg BUG=666901 Committed: https://crrev.com/8a23d79fa048dbd0a7309ac17c91e91afc9a04a3 Cr-Commit-Position: refs/heads/master@{#433423}

Patch Set 1 #

Patch Set 2 : restore failures #

Patch Set 3 : tweak expectations again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 7 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515573004/1
4 years, 1 month ago (2016-11-19 04:43:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515573004/20001
4 years, 1 month ago (2016-11-19 05:44:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515573004/40001
4 years, 1 month ago (2016-11-19 05:46:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/341241)
4 years, 1 month ago (2016-11-19 05:56:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515573004/40001
4 years, 1 month ago (2016-11-19 17:35:52 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-19 18:38:49 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 18:40:23 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8a23d79fa048dbd0a7309ac17c91e91afc9a04a3
Cr-Commit-Position: refs/heads/master@{#433423}

Powered by Google App Engine
This is Rietveld 408576698