Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2518653002:
memory coordinator: Set variation parameters if available (Closed)
Descriptionmemory coordinator: Set variation parameters if available
In V0 implementation we have several parameters to determine
the global state. Override these parameters when variations
are available.
BUG=617492
Committed: https://crrev.com/b935609873e0305e0666b89c4cff2c2a89901bf9
Cr-Commit-Position: refs/heads/master@{#433987}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Add DEPS #
Messages
Total messages: 30 (18 generated)
The CQ bit was checked by bashi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== memory coordinator: Set variation parameters if available In V0 implementation we have several parameters to determine the global state. Override these parameters when variations are available. We have to override these parameters in chrome/ as content/ sholdn't depend on components/variations. BUG=617492 ========== to ========== memory coordinator: Set variation parameters if available In V0 implementation we have several parameters to determine the global state. Override these parameters when variations are available. We have to override these parameters in chrome/ as content/ shouldn't depend on components/variations. BUG=617492 ==========
bashi@chromium.org changed reviewers: + chrisha@chromium.org, haraken@chromium.org
What do you think about this CL? I think we should have a way to tweak parameters. https://codereview.chromium.org/2518653002/diff/1/chrome/browser/memory/chrom... File chrome/browser/memory/chrome_memory_coordinator_delegate.cc (right): https://codereview.chromium.org/2518653002/diff/1/chrome/browser/memory/chrom... chrome/browser/memory/chrome_memory_coordinator_delegate.cc:71: static constexpr char kMemoryCoordinatorV0Trial[] = "MemoryCoordinatorV0"; I added "V0" suffix because we might want to do different experiments in the future. https://codereview.chromium.org/2518653002/diff/1/content/public/browser/memo... File content/public/browser/memory_coordinator_delegate.h (right): https://codereview.chromium.org/2518653002/diff/1/content/public/browser/memo... content/public/browser/memory_coordinator_delegate.h:13: struct MemoryCoordinatorV0Params { Exposing the details is bad, but I couldn't find a way to avoid it.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
Sami told me that we can depend on components/variations from content/. I'll update the CL later so please don't review this at this point.
The CQ bit was checked by bashi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== memory coordinator: Set variation parameters if available In V0 implementation we have several parameters to determine the global state. Override these parameters when variations are available. We have to override these parameters in chrome/ as content/ shouldn't depend on components/variations. BUG=617492 ========== to ========== memory coordinator: Set variation parameters if available In V0 implementation we have several parameters to determine the global state. Override these parameters when variations are available. BUG=617492 ==========
Done. PTAL?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
The CQ bit was checked by bashi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
bashi@chromium.org changed reviewers: + rkaplow@chromium.org
rkaplow@: Could you review DEPS?
lgtm
The CQ bit was checked by bashi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479850044131340,
"parent_rev": "6e424da3dc4ad243550f4ae392e9ce160469a80c", "commit_rev":
"73c4ef90a175d01e0a6584047be930b4356d27ca"}
Message was sent while issue was closed.
Description was changed from ========== memory coordinator: Set variation parameters if available In V0 implementation we have several parameters to determine the global state. Override these parameters when variations are available. BUG=617492 ========== to ========== memory coordinator: Set variation parameters if available In V0 implementation we have several parameters to determine the global state. Override these parameters when variations are available. BUG=617492 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== memory coordinator: Set variation parameters if available In V0 implementation we have several parameters to determine the global state. Override these parameters when variations are available. BUG=617492 ========== to ========== memory coordinator: Set variation parameters if available In V0 implementation we have several parameters to determine the global state. Override these parameters when variations are available. BUG=617492 Committed: https://crrev.com/b935609873e0305e0666b89c4cff2c2a89901bf9 Cr-Commit-Position: refs/heads/master@{#433987} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b935609873e0305e0666b89c4cff2c2a89901bf9 Cr-Commit-Position: refs/heads/master@{#433987} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
