Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: content/browser/memory/memory_coordinator_impl.cc

Issue 2518653002: memory coordinator: Set variation parameters if available (Closed)
Patch Set: Add DEPS Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/memory/memory_coordinator_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/memory/memory_coordinator_impl.cc
diff --git a/content/browser/memory/memory_coordinator_impl.cc b/content/browser/memory/memory_coordinator_impl.cc
index c5bf7f1e8afb655fbc89da76a044745565a69ae9..cffb7f2ed85e9145bd8d490b771d96773595e44d 100644
--- a/content/browser/memory/memory_coordinator_impl.cc
+++ b/content/browser/memory/memory_coordinator_impl.cc
@@ -6,8 +6,10 @@
#include "base/metrics/histogram_macros.h"
#include "base/process/process_metrics.h"
+#include "base/strings/string_number_conversions.h"
#include "base/threading/thread_task_runner_handle.h"
#include "base/trace_event/trace_event.h"
+#include "components/variations/variations_associated_data.h"
#include "content/browser/memory/memory_monitor.h"
#include "content/public/browser/notification_service.h"
#include "content/public/browser/notification_types.h"
@@ -109,6 +111,33 @@ void RecordMetricsOnStateChange(base::MemoryState prev_state,
#undef RECORD_METRICS
}
+void SetIntVariationParameter(const std::map<std::string, std::string> params,
+ const char* name,
+ int* target) {
+ const auto& iter = params.find(name);
+ if (iter == params.end())
+ return;
+ int value;
+ if (!iter->second.empty() && base::StringToInt(iter->second, &value)) {
+ DCHECK(value > 0);
+ *target = value;
+ }
+}
+
+void SetSecondsVariationParameter(
+ const std::map<std::string, std::string> params,
+ const char* name,
+ base::TimeDelta* target) {
+ const auto& iter = params.find(name);
+ if (iter == params.end())
+ return;
+ int value;
+ if (!iter->second.empty() && base::StringToInt(iter->second, &value)) {
+ DCHECK(value > 0);
+ *target = base::TimeDelta::FromSeconds(value);
+ }
+}
+
} // namespace
// SingletonTraits for MemoryCoordinator. Returns MemoryCoordinatorImpl
@@ -138,17 +167,7 @@ MemoryCoordinatorImpl::MemoryCoordinatorImpl(
DCHECK(memory_monitor_.get());
update_state_callback_ = base::Bind(&MemoryCoordinatorImpl::UpdateState,
weak_ptr_factory_.GetWeakPtr());
-
- // Set initial parameters for calculating the global state.
- expected_renderer_size_ = kDefaultExpectedRendererSizeMB;
- new_renderers_until_throttled_ = kDefaultNewRenderersUntilThrottled;
- new_renderers_until_suspended_ = kDefaultNewRenderersUntilSuspended;
- new_renderers_back_to_normal_ = kDefaultNewRenderersBackToNormal;
- new_renderers_back_to_throttled_ = kDefaultNewRenderersBackToThrottled;
- minimum_transition_period_ =
- base::TimeDelta::FromSeconds(kDefaultMinimumTransitionPeriodSeconds);
- monitoring_interval_ =
- base::TimeDelta::FromSeconds(kDefaultMonitoringIntervalSeconds);
+ InitializeParameters();
}
MemoryCoordinatorImpl::~MemoryCoordinatorImpl() {}
@@ -320,6 +339,37 @@ void MemoryCoordinatorImpl::ScheduleUpdateState(base::TimeDelta delta) {
task_runner_->PostDelayedTask(FROM_HERE, update_state_callback_, delta);
}
+void MemoryCoordinatorImpl::InitializeParameters() {
+ expected_renderer_size_ = kDefaultExpectedRendererSizeMB;
+ new_renderers_until_throttled_ = kDefaultNewRenderersUntilThrottled;
+ new_renderers_until_suspended_ = kDefaultNewRenderersUntilSuspended;
+ new_renderers_back_to_normal_ = kDefaultNewRenderersBackToNormal;
+ new_renderers_back_to_throttled_ = kDefaultNewRenderersBackToThrottled;
+ minimum_transition_period_ =
+ base::TimeDelta::FromSeconds(kDefaultMinimumTransitionPeriodSeconds);
+ monitoring_interval_ =
+ base::TimeDelta::FromSeconds(kDefaultMonitoringIntervalSeconds);
+
+ // Override default parameters with variations.
+ static constexpr char kMemoryCoordinatorV0Trial[] = "MemoryCoordinatorV0";
+ std::map<std::string, std::string> params;
+ variations::GetVariationParams(kMemoryCoordinatorV0Trial, &params);
+ SetIntVariationParameter(params, "expected_renderer_size",
+ &expected_renderer_size_);
+ SetIntVariationParameter(params, "new_renderers_until_throttled",
+ &new_renderers_until_throttled_);
+ SetIntVariationParameter(params, "new_renderers_until_suspended",
+ &new_renderers_until_suspended_);
+ SetIntVariationParameter(params, "new_renderers_back_to_normal",
+ &new_renderers_back_to_normal_);
+ SetIntVariationParameter(params, "new_renderers_back_to_throttled",
+ &new_renderers_back_to_throttled_);
+ SetSecondsVariationParameter(params, "minimum_transition_period",
+ &minimum_transition_period_);
+ SetSecondsVariationParameter(params, "monitoring_interval",
+ &monitoring_interval_);
+}
+
bool MemoryCoordinatorImpl::ValidateParameters() {
return (new_renderers_until_throttled_ > new_renderers_until_suspended_) &&
(new_renderers_back_to_normal_ > new_renderers_back_to_throttled_) &&
« no previous file with comments | « content/browser/memory/memory_coordinator_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698