Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2518623002: [DevTools]: Expose V8 version in /json/version (Closed)

Created:
4 years, 1 month ago by eostroukhov
Modified:
4 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, jam, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools]: Expose V8 version in /json/version BUG=660240 Committed: https://crrev.com/05636db85148178371d80a26af9f792cb2ba19b4 Cr-Commit-Position: refs/heads/master@{#433576}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/browser/devtools/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/devtools/devtools_http_handler.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
eostroukhov
This is an alternative cl to https://codereview.chromium.org/2472093003/ The change here is that I am allowing ...
4 years, 1 month ago (2016-11-18 19:31:50 UTC) #4
dgozman
I like this one, it's better! lgtm
4 years, 1 month ago (2016-11-18 19:35:24 UTC) #5
eostroukhov
Need OWNERS approval of the dependency.
4 years, 1 month ago (2016-11-18 19:42:21 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 1 month ago (2016-11-21 11:01:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518623002/1
4 years, 1 month ago (2016-11-21 16:29:52 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 17:21:24 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 17:24:01 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05636db85148178371d80a26af9f792cb2ba19b4
Cr-Commit-Position: refs/heads/master@{#433576}

Powered by Google App Engine
This is Rietveld 408576698