Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: content/browser/devtools/devtools_http_handler.cc

Issue 2518623002: [DevTools]: Expose V8 version in /json/version (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/devtools_http_handler.cc
diff --git a/content/browser/devtools/devtools_http_handler.cc b/content/browser/devtools/devtools_http_handler.cc
index 98841ec8cec7ab59e58aec0d2f723fe106b7bea6..bd980ec31a67daf646e1d0b7e976ebf5ac319b1d 100644
--- a/content/browser/devtools/devtools_http_handler.cc
+++ b/content/browser/devtools/devtools_http_handler.cc
@@ -37,6 +37,7 @@
#include "net/server/http_server_request_info.h"
#include "net/server/http_server_response_info.h"
#include "net/socket/server_socket.h"
+#include "v8/include/v8.h"
#if defined(OS_ANDROID)
#include "base/android/build_info.h"
@@ -524,6 +525,7 @@ void DevToolsHttpHandler::OnJsonRequest(
version.SetString("WebKit-Version", GetWebKitVersion());
version.SetString("Browser", product_name_);
version.SetString("User-Agent", user_agent_);
+ version.SetString("V8-Version", v8::V8::GetVersion());
#if defined(OS_ANDROID)
version.SetString("Android-Package",
base::android::BuildInfo::GetInstance()->package_name());
« no previous file with comments | « content/browser/devtools/DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698