Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2518583002:
[ObjC ARC] Converts ios/chrome/browser/web:web to ARC. (Closed)
|
Created:
4 years, 1 month ago by stkhapugin Modified:
4 years ago CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org, lpromero Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[ObjC ARC] Converts ios/chrome/browser/web:web to ARC.
Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
Committed: https://crrev.com/58a14298b8d714a8f67b4559867d256c5b3047dc
Cr-Commit-Position: refs/heads/master@{#438883}
Patch Set 1 #Patch Set 2 : Removes scoped_block and scoped_nsobject #
Total comments: 2
Patch Set 3 : comments #Patch Set 4 : rebase #
Messages
Total messages: 42 (24 generated)
The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
stkhapugin@chromium.org changed reviewers: + sdefresne@chromium.org
PTAL. The issue passed downstream trybots.
lgtm
The CQ bit was checked by stkhapugin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
CC lpromero FYI
The CQ bit was checked by stkhapugin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sdefresne@chromium.org Link to the patchset: https://codereview.chromium.org/2518583002/#ps20001 (title: "Removes scoped_block and scoped_nsobject")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lpromero@chromium.org changed reviewers: + lpromero@chromium.org
https://codereview.chromium.org/2518583002/diff/20001/ios/chrome/browser/web/... File ios/chrome/browser/web/resubmit_data_controller.mm (right): https://codereview.chromium.org/2518583002/diff/20001/ios/chrome/browser/web/... ios/chrome/browser/web/resubmit_data_controller.mm:45: continueBlock = [^() { Remove this.
The CQ bit was unchecked by lpromero@chromium.org
Description was changed from ========== [ObjC ARC] Converts ios/chrome/browser/web:web to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None ========== to ========== [ObjC ARC] Converts ios/chrome/browser/web:web to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None ==========
PTAL https://codereview.chromium.org/2518583002/diff/20001/ios/chrome/browser/web/... File ios/chrome/browser/web/resubmit_data_controller.mm (right): https://codereview.chromium.org/2518583002/diff/20001/ios/chrome/browser/web/... ios/chrome/browser/web/resubmit_data_controller.mm:45: continueBlock = [^() { On 2016/12/05 14:39:10, lpromero wrote: > Remove this. Done.
The CQ bit was checked by lpromero@chromium.org
lgtm Just seeing I had to approve this. Sorry for the delay.
The patchset sent to the CQ was uploaded after l-g-t-m from sdefresne@chromium.org Link to the patchset: https://codereview.chromium.org/2518583002/#ps40001 (title: "comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for ios/chrome/browser/web/BUILD.gn:
While running git apply --index -p1;
error: patch failed: ios/chrome/browser/web/BUILD.gn:3
error: ios/chrome/browser/web/BUILD.gn: patch does not apply
Patch: ios/chrome/browser/web/BUILD.gn
Index: ios/chrome/browser/web/BUILD.gn
diff --git a/ios/chrome/browser/web/BUILD.gn b/ios/chrome/browser/web/BUILD.gn
index
3f59b9bb327567b74d5aa4214b0621cb345898cd..4120c29066b75454909803c4578b106f03a44fb7
100644
--- a/ios/chrome/browser/web/BUILD.gn
+++ b/ios/chrome/browser/web/BUILD.gn
@@ -3,6 +3,7 @@
# found in the LICENSE file.
source_set("web") {
+ configs += [ "//build/config/compiler:enable_arc" ]
sources = [
"dom_altering_lock.h",
"dom_altering_lock.mm",
The CQ bit was checked by stkhapugin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sdefresne@chromium.org, lpromero@chromium.org Link to the patchset: https://codereview.chromium.org/2518583002/#ps60001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by stkhapugin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by stkhapugin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481819264662010,
"parent_rev": "0f96eb94a25ec43d60a4c9091b50f78ce9b3dcee", "commit_rev":
"7cc5cb34efd88226a2e646b092fa63a7c272d061"}
Message was sent while issue was closed.
Description was changed from ========== [ObjC ARC] Converts ios/chrome/browser/web:web to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None ========== to ========== [ObjC ARC] Converts ios/chrome/browser/web:web to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2518583002 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [ObjC ARC] Converts ios/chrome/browser/web:web to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2518583002 ========== to ========== [ObjC ARC] Converts ios/chrome/browser/web:web to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/58a14298b8d714a8f67b4559867d256c5b3047dc Cr-Commit-Position: refs/heads/master@{#438883} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/58a14298b8d714a8f67b4559867d256c5b3047dc Cr-Commit-Position: refs/heads/master@{#438883} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
