Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: icu.gyp

Issue 2518533002: Fix big endian support for MIPS (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: icu.gyp
diff --git a/icu.gyp b/icu.gyp
index 69bf254ed8abb08083461f6b04127a816595cf34..0a3ea38aa7805f29610cf92863e54504d40c39c6 100644
--- a/icu.gyp
+++ b/icu.gyp
@@ -105,7 +105,11 @@
} , { # else: OS != android
'conditions': [
# Big Endian
- [ 'v8_host_byteorder=="big"', {
+ [ 'target_arch=="mips" or target_arch=="mips64"', {
+ 'files': [
+ 'common/icudtb.dat',
+ ],
+ }, 'v8_host_byteorder=="big"', {
jungshik at Google 2016/11/21 23:45:25 can you just OR 'v8_host_byteorder==big' with 'tar
'files': [
'common/icudtb.dat',
],
@@ -123,7 +127,14 @@
'target_name': 'data_assembly',
'type': 'none',
'conditions': [
- [ 'v8_host_byteorder=="big"', { # Big Endian
+ [ 'target_arch=="mips" or target_arch=="mips64"', {
+ 'data_assembly_inputs': [
+ 'common/icudtb.dat',
+ ],
+ 'data_assembly_outputs': [
+ '<(SHARED_INTERMEDIATE_DIR)/third_party/icu/icudtb_dat.S',
+ ],
+ }, 'v8_host_byteorder=="big"', { # Big Endian
jungshik at Google 2016/11/21 23:45:25 The same here...
'data_assembly_inputs': [
'common/icudtb.dat',
],
@@ -186,7 +197,9 @@
'<(SHARED_INTERMEDIATE_DIR)/third_party/icu/icudtb_dat.S',
],
'conditions': [
- [ 'v8_host_byteorder=="big"', {
+ [ 'target_arch=="mips" or target_arch=="mips64"', {
+ 'sources!': ['<(SHARED_INTERMEDIATE_DIR)/third_party/icu/icudtl_dat.S'],
+ }, 'v8_host_byteorder=="big"', {
'sources!': ['<(SHARED_INTERMEDIATE_DIR)/third_party/icu/icudtl_dat.S'],
}, {
'sources!': ['<(SHARED_INTERMEDIATE_DIR)/third_party/icu/icudtb_dat.S'],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698