Fix big endian support for MIPS

icu.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'includes': [
     'icu.gypi',
   ],
   'variables': {
     'use_system_icu%': 0,
@@ skipping 87 matching lines @@
           'copies': [{
             'destination': '<(PRODUCT_DIR)',
             'conditions': [
               ['OS == "android"', {
                 'files': [
                   'android/icudtl.dat',
                 ],
               } , { # else: OS != android
                 'conditions': [
                   # Big Endian
-                  [ 'v8_host_byteorder=="big"', {
+                  [ 'target_arch=="mips" or target_arch=="mips64"', {
                     'files': [
                       'common/icudtb.dat',
                     ],
+                  }, 'v8_host_byteorder=="big"', {

[jungshik at Google, 2016/11/21 23:45:25]

can you just OR 'v8_host_byteorder==big' with 'target_arch==... mips64"'?  

+                    'files': [
+                      'common/icudtb.dat',
+                    ],
                   } , {  # else: ! Big Endian = Little Endian
                     'files': [
                       'common/icudtl.dat',
                     ],
                   }],
                 ],
               }],
             ],
           }],
         },
         {
           'target_name': 'data_assembly',
           'type': 'none',
           'conditions': [
-            [ 'v8_host_byteorder=="big"', { # Big Endian
+            [ 'target_arch=="mips" or target_arch=="mips64"', {
               'data_assembly_inputs': [
                 'common/icudtb.dat',
               ],
+              'data_assembly_outputs': [
+                '<(SHARED_INTERMEDIATE_DIR)/third_party/icu/icudtb_dat.S',
+              ],
+            }, 'v8_host_byteorder=="big"', { # Big Endian

[jungshik at Google, 2016/11/21 23:45:25]

The same here...

+              'data_assembly_inputs': [
+                'common/icudtb.dat',
+              ],
               'data_assembly_outputs': [
                 '<(SHARED_INTERMEDIATE_DIR)/third_party/icu/icudtb_dat.S',
               ],
             }, { # Little Endian
               'data_assembly_outputs': [
                 '<(SHARED_INTERMEDIATE_DIR)/third_party/icu/icudtl_dat.S',
               ],
               'conditions': [
                 ['OS == "android"', {
                   'data_assembly_inputs': [
@@ skipping 39 matching lines @@
             'U_HIDE_DATA_SYMBOL',
           ],
           'dependencies': [
             'data_assembly#target',
           ],
           'sources': [
              '<(SHARED_INTERMEDIATE_DIR)/third_party/icu/icudtl_dat.S',
              '<(SHARED_INTERMEDIATE_DIR)/third_party/icu/icudtb_dat.S',
           ],
           'conditions': [
-            [ 'v8_host_byteorder=="big"', {
+            [ 'target_arch=="mips" or target_arch=="mips64"', {
+              'sources!': ['<(SHARED_INTERMEDIATE_DIR)/third_party/icu/icudtl_dat.S'],
+            }, 'v8_host_byteorder=="big"', {
               'sources!': ['<(SHARED_INTERMEDIATE_DIR)/third_party/icu/icudtl_dat.S'],
             }, {
               'sources!': ['<(SHARED_INTERMEDIATE_DIR)/third_party/icu/icudtb_dat.S'],
             }],
             [ 'use_system_icu==1 and want_separate_host_toolset==1', {
               'toolsets': ['host'],
             }],
             [ 'use_system_icu==0 and want_separate_host_toolset==1', {
               'toolsets': ['host', 'target'],
             }],
@@ skipping 480 matching lines @@
           },
           'includes': [
             'shim_headers.gypi',
           ],
           'toolsets': ['target'],
         },
       ], # targets
     }],
   ], # conditions
 }