Remove obsolete plugin state handling code.

chrome/browser/pdf/pdf_extension_test.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <vector>
 
 #include "base/base_paths.h"
 #include "base/files/file_enumerator.h"
@@ skipping 12 matching lines @@
 #include "chrome/browser/pdf/pdf_extension_test_util.h"
 #include "chrome/browser/pdf/pdf_extension_util.h"
 #include "chrome/browser/plugins/plugin_prefs.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_content_client.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
+#include "chrome/common/pref_names.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/zoom/page_zoom.h"
 #include "components/zoom/test/zoom_test_utils.h"
 #include "components/zoom/zoom_controller.h"
 #include "content/public/browser/browser_accessibility_state.h"
 #include "content/public/browser/browser_plugin_guest_manager.h"
 #include "content/public/browser/download_item.h"
 #include "content/public/browser/download_manager.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
@@ skipping 233 matching lines @@
         &x));
 
     int y;
     ASSERT_TRUE(content::ExecuteScriptAndExtractInt(
         contents,
         "window.domAutomationController.send(linkScreenPositionY);",
         &y));
 
     point->SetPoint(x, y);
   }
-
 };
 
 IN_PROC_BROWSER_TEST_P(PDFExtensionTest, Load) {
 #if defined(GOOGLE_CHROME_BUILD)
   // Load private PDFs.
   LoadAllPdfsTest("pdf_private", GetParam());
 #endif
   // Load public PDFs.
   LoadAllPdfsTest("pdf", GetParam());
 }
 
-class DisablePluginHelper : public content::DownloadManager::Observer,
-                            public content::NotificationObserver {
+class DisablePluginHelper : public content::DownloadManager::Observer {
  public:
   DisablePluginHelper() {}
   ~DisablePluginHelper() override {}
 
   void DisablePlugin(Profile* profile) {
-    registrar_.Add(this, chrome::NOTIFICATION_PLUGIN_ENABLE_STATUS_CHANGED,
-                   content::Source<Profile>(profile));
-    scoped_refptr<PluginPrefs> prefs(PluginPrefs::GetForProfile(profile));
-    DCHECK(prefs.get());
-    prefs->EnablePluginGroup(
-        false, base::UTF8ToUTF16(ChromeContentClient::kPDFPluginName));
-    // Wait until the plugin has been disabled.
-    disable_run_loop_.Run();
+    profile->GetPrefs()->SetBoolean(
+        prefs::kPluginsAlwaysOpenPdfExternally, true);
   }
 
   const GURL& GetLastUrl() {
     // Wait until the download has been created.
     download_run_loop_.Run();
     return last_url_;
   }
 
   // content::DownloadManager::Observer implementation.
   void OnDownloadCreated(content::DownloadManager* manager,
                          content::DownloadItem* item) override {
     last_url_ = item->GetURL();
     download_run_loop_.Quit();
   }
 
-  // content::NotificationObserver implementation.
-  void Observe(int type,
-               const content::NotificationSource& source,
-               const content::NotificationDetails& details) override {
-    DCHECK_EQ(chrome::NOTIFICATION_PLUGIN_ENABLE_STATUS_CHANGED, type);
-    disable_run_loop_.Quit();
-  }
-
  private:
   content::NotificationRegistrar registrar_;
-  base::RunLoop disable_run_loop_;
   base::RunLoop download_run_loop_;
   GURL last_url_;
 };
 
 IN_PROC_BROWSER_TEST_F(PDFExtensionTest, DisablePlugin) {
   // Disable the PDF plugin.
   content::WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   content::BrowserContext* browser_context = web_contents->GetBrowserContext();
   Profile* profile = Profile::FromBrowserContext(browser_context);
@@ skipping 565 matching lines @@
   const GURL& url = active_web_contents->GetURL();
   ASSERT_EQ(std::string("http://www.example.com/"), url.spec());
 }
 
 // Test that if the plugin tries to load a URL that redirects then it will fail
 // to load. This is to avoid the source origin of the document changing during
 // the redirect, which can have security implications. https://crbug.com/653749.
 IN_PROC_BROWSER_TEST_F(PDFExtensionTest, RedirectsFailInPlugin) {
   RunTestsInFile("redirects_fail_test.js", "test.pdf");
 }