Fixing Chromium Android build's reliance on old SkPicture recording API

Fixing Chromium Android build's reliance on old SkPicture recording API

Skia is moving to an API where SkPicture can no longer invoke beginRecording/endRecording on itself. This functionality is deferred to a separate SkPictureRecorder object to clarify when SkPictures are complete (and make them immutable). This CL updates webview to the new interface.

torne for OWNER review
fmalita for skia-side review

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267210

[f(malita), 2014-04-29 17:26:59]

Non-owner lgtm + nit.

https://codereview.chromium.org/251843005/diff/80001/android_webview/browser/...
File android_webview/browser/browser_view_renderer.cc (right):

https://codereview.chromium.org/251843005/diff/80001/android_webview/browser/...
android_webview/browser/browser_view_renderer.cc:164: skia::RefPtr<SkPicture>
picture(skia::AdoptRef(recorder.endRecording()));
return skia::AdoptRef(recorder.endRecording());

[boliu, 2014-04-29 18:12:53]

owner lgtm

[robertphillips, 2014-04-29 19:14:31]

https://codereview.chromium.org/251843005/diff/80001/android_webview/browser/...
File android_webview/browser/browser_view_renderer.cc (right):

https://codereview.chromium.org/251843005/diff/80001/android_webview/browser/...
android_webview/browser/browser_view_renderer.cc:164: skia::RefPtr<SkPicture>
picture(skia::AdoptRef(recorder.endRecording()));
On 2014/04/29 17:26:59, Florin Malita wrote:
> return skia::AdoptRef(recorder.endRecording());

Done.

[robertphillips, 2014-04-29 19:14:43]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-04-29 19:16:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertphillips@google.com/251843005/10...

[commit-bot: I haz the power, 2014-04-29 19:29:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 19:29:35]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium

[robertphillips, 2014-04-30 11:51:33]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-04-30 11:51:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertphillips@google.com/251843005/10...

[commit-bot: I haz the power, 2014-04-30 12:14:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-30 12:14:27]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium

[robertphillips, 2014-04-30 12:20:41]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-04-30 12:20:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertphillips@google.com/251843005/10...

[commit-bot: I haz the power, 2014-04-30 14:55:04]

Change committed as 267210