Add validation to the mailbox functions in the passthrough cmd decoder.

Add validation to the mailbox functions in the passthrough cmd decoder.

BUG=602688
BUG=665518
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/45a7bad6d01848750b92db29f1f7eac0375fc4b9
Cr-Commit-Position: refs/heads/master@{#434191}

[Geoff Lang, 2016-11-22 15:54:23]

Description was changed from

==========
Add validation to the mailbox functions in the passthrough cmd decoder.

BUG=602688
==========

to

==========
Add validation to the mailbox functions in the passthrough cmd decoder.

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Geoff Lang, 2016-11-22 15:55:14]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 15:55:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Geoff Lang, 2016-11-22 16:40:47]

Description was changed from

==========
Add validation to the mailbox functions in the passthrough cmd decoder.

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add validation to the mailbox functions in the passthrough cmd decoder.

BUG=602688
BUG=665518
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Geoff Lang, 2016-11-22 16:50:09]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 16:50:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Geoff Lang, 2016-11-22 16:51:00]

geofflang@chromium.org changed reviewers:
+ piman@chromium.org

[Geoff Lang, 2016-11-22 16:51:01]

PTAL, passes all the gl_tests for mailboxes except the ones for taking/returning
the front buffer.

[commit-bot: I haz the power, 2016-11-22 18:13:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 18:13:24]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[piman, 2016-11-22 23:06:10]

lgtm

https://codereview.chromium.org/2518413002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/texture_manager.h (right):

https://codereview.chromium.org/2518413002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/texture_manager.h:48: TextureBase(GLuint service_id);
nit: keep explicit

[Geoff Lang, 2016-11-23 15:08:52]

https://codereview.chromium.org/2518413002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/texture_manager.h (right):

https://codereview.chromium.org/2518413002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/texture_manager.h:48: TextureBase(GLuint service_id);
On 2016/11/22 23:06:10, piman wrote:
> nit: keep explicit

Whoops, removed the wrong explicit.

[Geoff Lang, 2016-11-23 15:09:28]

The CQ bit was checked by geofflang@chromium.org

[Geoff Lang, 2016-11-23 15:09:29]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2518413002/#ps40001
(title: "Fix explicit.")

[commit-bot: I haz the power, 2016-11-23 15:09:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 15:57:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 15:57:16]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Geoff Lang, 2016-11-23 15:59:13]

The CQ bit was checked by geofflang@chromium.org

[commit-bot: I haz the power, 2016-11-23 15:59:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 17:05:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479916753061710,
"parent_rev": "9b07812f6c1446a90026c9c07a93c32962d85d2e", "commit_rev":
"447f5138bbf052ee3082d111c7c916bd0c121949"}

[commit-bot: I haz the power, 2016-11-23 17:06:05]

Description was changed from

==========
Add validation to the mailbox functions in the passthrough cmd decoder.

BUG=602688
BUG=665518
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add validation to the mailbox functions in the passthrough cmd decoder.

BUG=602688
BUG=665518
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-23 17:06:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-23 17:08:14]

Description was changed from

==========
Add validation to the mailbox functions in the passthrough cmd decoder.

BUG=602688
BUG=665518
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add validation to the mailbox functions in the passthrough cmd decoder.

BUG=602688
BUG=665518
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/45a7bad6d01848750b92db29f1f7eac0375fc4b9
Cr-Commit-Position: refs/heads/master@{#434191}
==========

[commit-bot: I haz the power, 2016-11-23 17:08:15]

Patchset 3 (id:??) landed as
https://crrev.com/45a7bad6d01848750b92db29f1f7eac0375fc4b9
Cr-Commit-Position: refs/heads/master@{#434191}