Add validation to the mailbox functions in the passthrough cmd decoder.

gpu/command_buffer/service/texture_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/texture_manager.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 421 matching lines @@
   }
 
   if (have_context) {
     glDeleteTextures(arraysize(black_texture_ids_), black_texture_ids_);
   }
 
   DCHECK_EQ(0u, memory_type_tracker_->GetMemRepresented());
 }
 
 TextureBase::TextureBase(GLuint service_id)
-    : service_id_(service_id), mailbox_manager_(nullptr) {}
+    : service_id_(service_id), target_(GL_NONE), mailbox_manager_(nullptr) {}
 
 TextureBase::~TextureBase() {
   DCHECK_EQ(nullptr, mailbox_manager_);
 }
 
+void TextureBase::SetTarget(GLenum target) {
+  DCHECK_EQ(0u, target_);  // you can only set this once.
+  target_ = target;
+}
+
 void TextureBase::DeleteFromMailboxManager() {
   if (mailbox_manager_) {
     mailbox_manager_->TextureDeleted(this);
     mailbox_manager_ = nullptr;
   }
 }
 
 void TextureBase::SetMailboxManager(MailboxManager* mailbox_manager) {
   DCHECK(!mailbox_manager_ || mailbox_manager_ == mailbox_manager);
   mailbox_manager_ = mailbox_manager;
 }
 
-TexturePassthrough::TexturePassthrough(GLuint service_id)
-    : TextureBase(service_id), have_context_(true) {}
+TexturePassthrough::TexturePassthrough(GLuint service_id, GLenum target)
+    : TextureBase(service_id), have_context_(true) {
+  TextureBase::SetTarget(target);
+}
 
 TexturePassthrough::~TexturePassthrough() {
   DeleteFromMailboxManager();
   if (have_context_) {
     glDeleteTextures(1, &service_id_);
   }
 }
 
 void TexturePassthrough::MarkContextLost() {
   have_context_ = false;
 }
 
 Texture::Texture(GLuint service_id)
     : TextureBase(service_id),
       memory_tracking_ref_(NULL),
       owned_service_id_(service_id),
       cleared_(true),
       num_uncleared_mips_(0),
       num_npot_faces_(0),
-      target_(0),
       usage_(GL_NONE),
       base_level_(0),
       max_level_(1000),
       swizzle_r_(GL_RED),
       swizzle_g_(GL_GREEN),
       swizzle_b_(GL_BLUE),
       swizzle_a_(GL_ALPHA),
       max_level_set_(-1),
       texture_complete_(false),
       texture_mips_dirty_(false),
@@ skipping 247 matching lines @@
       height = std::max(1, height >> 1);
       depth = target == GL_TEXTURE_2D_ARRAY ? depth : std::max(1, depth >> 1);
       SetLevelInfo(target, level, level0_info.internal_format,
                    width, height, depth, level0_info.border, level0_info.format,
                    level0_info.type, gfx::Rect(width, height));
     }
   }
 }
 
 void Texture::SetTarget(GLenum target, GLint max_levels) {
-  DCHECK_EQ(0u, target_);  // you can only set this once.
-  target_ = target;
+  TextureBase::SetTarget(target);
   size_t num_faces = (target == GL_TEXTURE_CUBE_MAP) ? 6 : 1;
   face_infos_.resize(num_faces);
   for (size_t ii = 0; ii < num_faces; ++ii) {
     face_infos_[ii].level_infos.resize(max_levels);
   }
 
   if (target == GL_TEXTURE_EXTERNAL_OES || target == GL_TEXTURE_RECTANGLE_ARB) {
     sampler_state_.min_filter = GL_LINEAR;
     sampler_state_.wrap_s = sampler_state_.wrap_t = GL_CLAMP_TO_EDGE;
   }
@@ skipping 2885 matching lines @@
 uint32_t TextureManager::GetServiceIdGeneration() const {
   return current_service_id_generation_;
 }
 
 void TextureManager::IncrementServiceIdGeneration() {
   current_service_id_generation_++;
 }
 
 }  // namespace gles2
 }  // namespace gpu