third_party/WebKit/Source/core/layout/ScrollAnchor.cpp - Issue 2518363003: Refactor InlineBox::calculateBoundaries()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ScrollAnchor.cpp

Issue 2518363003: Refactor InlineBox::calculateBoundaries() (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ScrollAnchor.cpp

diff --git a/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp b/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp

index b791d4ed415ca96b0b760ee2eed95ce9160b79e9..bfdedc3edbd13b6e6f5a8c034258991283e01dcd 100644

--- a/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp

+++ b/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp

@@ -93,7 +93,7 @@ static LayoutRect relativeBounds(const LayoutObject* layoutObject,

// TODO(skobes): Use first and last InlineTextBox only?

for (InlineTextBox* box = toLayoutText(layoutObject)->firstTextBox(); box;

box = box->nextTextBox())

- localBounds.unite(box->calculateBoundaries());

+ localBounds.unite(box->frameRect());

} else {

// Only LayoutBox and LayoutText are supported.

ASSERT_NOT_REACHED();