Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutText.cpp

Issue 2518363003: Refactor InlineBox::calculateBoundaries() (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutText.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutText.cpp b/third_party/WebKit/Source/core/layout/LayoutText.cpp
index cd988173ecf8f8c9027ca00b6b605c78f398bd3f..f82dcd054e2c1ca8d75f99de00f3ec5caa95fa08 100644
--- a/third_party/WebKit/Source/core/layout/LayoutText.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutText.cpp
@@ -373,7 +373,7 @@ void LayoutText::absoluteRectsForRange(Vector<IntRect>& rects,
// Note: box->end() returns the index of the last character, not the index
// past it
if (start <= box->start() && box->end() < end) {
- FloatRect r(box->calculateBoundaries());
+ FloatRect r(box->frameRect());
if (useSelectionHeight) {
LayoutRect selectionRect = box->localSelectionRect(start, end);
if (box->isHorizontal()) {
@@ -425,7 +425,7 @@ void LayoutText::quads(Vector<FloatQuad>& quads,
ClippingOption option,
LocalOrAbsoluteOption localOrAbsolute) const {
for (InlineTextBox* box = firstTextBox(); box; box = box->nextTextBox()) {
- FloatRect boundaries(box->calculateBoundaries());
+ FloatRect boundaries(box->frameRect());
// Shorten the width of this text box if it ends in an ellipsis.
// FIXME: ellipsisRectForBox should switch to return FloatRect soon with the
@@ -478,7 +478,7 @@ void LayoutText::absoluteQuadsForRange(Vector<FloatQuad>& quads,
// Note: box->end() returns the index of the last character, not the index
// past it
if (start <= box->start() && box->end() < end) {
- LayoutRect r(box->calculateBoundaries());
+ LayoutRect r(box->frameRect());
if (useSelectionHeight) {
LayoutRect selectionRect = box->localSelectionRect(start, end);
if (box->isHorizontal()) {
« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp ('k') | third_party/WebKit/Source/core/layout/ScrollAnchor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698