third_party/WebKit/Source/core/layout/line/InlineTextBox.h - Issue 2518363003: Refactor InlineBox::calculateBoundaries()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineTextBox.h

Issue 2518363003: Refactor InlineBox::calculateBoundaries() (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/line/InlineTextBox.h

diff --git a/third_party/WebKit/Source/core/layout/line/InlineTextBox.h b/third_party/WebKit/Source/core/layout/line/InlineTextBox.h

index 66adff4fc6ea3d67301d7c892fbc913b03e54831..8c0650a7a8618ae6135e7374484fc56d200825c4 100644

--- a/third_party/WebKit/Source/core/layout/line/InlineTextBox.h

+++ b/third_party/WebKit/Source/core/layout/line/InlineTextBox.h

@@ -127,7 +127,7 @@ class CORE_EXPORT InlineTextBox : public InlineBox {

public:

TextRun constructTextRunForInspector(const ComputedStyle&) const;

- LayoutRect calculateBoundaries() const override {

+ LayoutRect frameRect() const {

pdr. 2016/11/23 03:38:12 This name looks correct (e.g., it is similar to th

Xianzhu 2016/11/23 04:06:37 Yes. It's in the "physical coordinates (flipped if

return LayoutRect(x(), y(), width(), height());

}