third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp - Issue 2518363003: Refactor InlineBox::calculateBoundaries()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

Issue 2518363003: Refactor InlineBox::calculateBoundaries() (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

index 466390d3ab748d0bde2d8bc0fc0592ddf9eb7790..eb984c0fa05ddb6a38b04ca01190ff92b89e932c 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

@@ -122,7 +122,7 @@ LayoutRect LayoutSVGInlineText::localCaretRect(InlineBox* box,

FloatRect LayoutSVGInlineText::floatLinesBoundingBox() const {

FloatRect boundingBox;

for (InlineTextBox* box = firstTextBox(); box; box = box->nextTextBox())

- boundingBox.unite(FloatRect(box->calculateBoundaries()));

+ boundingBox.unite(FloatRect(box->frameRect()));

return boundingBox;

}