Refactor InlineBox::calculateBoundaries()

Refactor InlineBox::calculateBoundaries()

Previously calculateBoundaries() were used for two different purposes:
- For InlineTextBox, this is to retrieve the frame rect (LayoutRect(x(),
  y(), width(), height()) which is a result of layout.
- For SVGInlineFlowBox and SVGInlineTextBox this is a task during layout
  to calculate the boundaries based on the positions of text fragments.

Remove InlineBox::calculateBoundaries() because we don't need it in
this abstraction level.

Rename InlineTextBox::calculateBoundaries() to frameRect().

Keep SVGInlineTextBox::calculateBoundaries() which is no longer virtual.

BUG=666416
Committed: https://crrev.com/5d66facc4263f517ee3cd4d733120bc9e5380cd1
Cr-Commit-Position: refs/heads/master@{#434907}

[Xianzhu, 2016-11-23 00:01:58]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 00:03:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-11-23 00:18:59]

wangxianzhu@chromium.org changed reviewers:
+ pdr@chromium.org

[commit-bot: I haz the power, 2016-11-23 01:50:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 01:50:05]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pdr., 2016-11-23 03:38:13]

Very nice cleanup.

LGTM

https://codereview.chromium.org/2518363003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/line/InlineTextBox.h (right):

https://codereview.chromium.org/2518363003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/line/InlineTextBox.h:130: LayoutRect
frameRect() const {
This name looks correct (e.g., it is similar to the existing logicalFrameRect).

Question though: is this frameRect in the same coordinate space as
LayoutBox::frameRect?

[Xianzhu, 2016-11-23 04:06:37]

I found I have to make this CL the last one in the series because for now the
SVG line boxes still have two difference coordinates spaces (local SVG
coordinates and local HTML coordinates). The coordinates of text fragments and
result of calculateBoundaries() are in local SVG coordinates and frameRect() is
in local HTML coordinates.

The remaining CLs in the series are:
1. fix wrong logical/physical coordinates issue of SVG line boxes,
2. unify SVG and HTML coordinate spaces for SVG line boxes,
3. this one,
4. make LayoutSVGForeignObject::visualRectInLocalSVGCoordinates really in local
SVG coordintes.

https://codereview.chromium.org/2518363003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/line/InlineTextBox.h (right):

https://codereview.chromium.org/2518363003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/line/InlineTextBox.h:130: LayoutRect
frameRect() const {
On 2016/11/23 03:38:12, pdr. wrote:
> This name looks correct (e.g., it is similar to the existing
logicalFrameRect).
> 
> Question though: is this frameRect in the same coordinate space as
> LayoutBox::frameRect?

Yes. It's in the "physical coordinates (flipped if vertical-rl)" of the LineBox
in the containing block.

[Xianzhu, 2016-11-29 04:34:26]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-11-29 04:34:26]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2518363003/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-29 04:34:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-11-29 05:24:47]

Description was changed from

==========
Refactor InlineBox::calculateBoundaries()

Previously calculateBoundaries() were used for two different purposes:
- For InlineTextBox, this is to retrieve the frame rect (LayoutRect(x(),
  y(), width(), height()) which is a result of layout.
- For SVGInlineFlowBox and SVGInlineTextBox this is a task during layout
  to calculate the boundaries based on the positions of text fragments.

Remove InlineBox::calculateBoundaries() because we don't need it in
this abstraction level.

Rename InlineTextBox::calculateBoundaries() to frameRect().

Keep calculateBoundaries() of SVGInlineFlowBox and SVGInlineTextBox but
they are no longer virtual.

BUG=666416
==========

to

==========
Refactor InlineBox::calculateBoundaries()

Previously calculateBoundaries() were used for two different purposes:
- For InlineTextBox, this is to retrieve the frame rect (LayoutRect(x(),
  y(), width(), height()) which is a result of layout.
- For SVGInlineFlowBox and SVGInlineTextBox this is a task during layout
  to calculate the boundaries based on the positions of text fragments.

Remove InlineBox::calculateBoundaries() because we don't need it in
this abstraction level.

Rename InlineTextBox::calculateBoundaries() to frameRect().

Keep SVGInlineTextBox::calculateBoundaries() which is no longer virtual.

BUG=666416
==========

[commit-bot: I haz the power, 2016-11-29 05:56:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480394066122180,
"parent_rev": "ff691d39dcb054d5507dc763e881aea44737505b", "commit_rev":
"b212d96885145b26252ef9872a3ec9da8ab3639f"}

[commit-bot: I haz the power, 2016-11-29 05:57:26]

Description was changed from

==========
Refactor InlineBox::calculateBoundaries()

Previously calculateBoundaries() were used for two different purposes:
- For InlineTextBox, this is to retrieve the frame rect (LayoutRect(x(),
  y(), width(), height()) which is a result of layout.
- For SVGInlineFlowBox and SVGInlineTextBox this is a task during layout
  to calculate the boundaries based on the positions of text fragments.

Remove InlineBox::calculateBoundaries() because we don't need it in
this abstraction level.

Rename InlineTextBox::calculateBoundaries() to frameRect().

Keep SVGInlineTextBox::calculateBoundaries() which is no longer virtual.

BUG=666416
==========

to

==========
Refactor InlineBox::calculateBoundaries()

Previously calculateBoundaries() were used for two different purposes:
- For InlineTextBox, this is to retrieve the frame rect (LayoutRect(x(),
  y(), width(), height()) which is a result of layout.
- For SVGInlineFlowBox and SVGInlineTextBox this is a task during layout
  to calculate the boundaries based on the positions of text fragments.

Remove InlineBox::calculateBoundaries() because we don't need it in
this abstraction level.

Rename InlineTextBox::calculateBoundaries() to frameRect().

Keep SVGInlineTextBox::calculateBoundaries() which is no longer virtual.

BUG=666416
==========

[commit-bot: I haz the power, 2016-11-29 05:57:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-29 05:59:05]

Description was changed from

==========
Refactor InlineBox::calculateBoundaries()

Previously calculateBoundaries() were used for two different purposes:
- For InlineTextBox, this is to retrieve the frame rect (LayoutRect(x(),
  y(), width(), height()) which is a result of layout.
- For SVGInlineFlowBox and SVGInlineTextBox this is a task during layout
  to calculate the boundaries based on the positions of text fragments.

Remove InlineBox::calculateBoundaries() because we don't need it in
this abstraction level.

Rename InlineTextBox::calculateBoundaries() to frameRect().

Keep SVGInlineTextBox::calculateBoundaries() which is no longer virtual.

BUG=666416
==========

to

==========
Refactor InlineBox::calculateBoundaries()

Previously calculateBoundaries() were used for two different purposes:
- For InlineTextBox, this is to retrieve the frame rect (LayoutRect(x(),
  y(), width(), height()) which is a result of layout.
- For SVGInlineFlowBox and SVGInlineTextBox this is a task during layout
  to calculate the boundaries based on the positions of text fragments.

Remove InlineBox::calculateBoundaries() because we don't need it in
this abstraction level.

Rename InlineTextBox::calculateBoundaries() to frameRect().

Keep SVGInlineTextBox::calculateBoundaries() which is no longer virtual.

BUG=666416

Committed: https://crrev.com/5d66facc4263f517ee3cd4d733120bc9e5380cd1
Cr-Commit-Position: refs/heads/master@{#434907}
==========

[commit-bot: I haz the power, 2016-11-29 05:59:06]

Patchset 2 (id:??) landed as
https://crrev.com/5d66facc4263f517ee3cd4d733120bc9e5380cd1
Cr-Commit-Position: refs/heads/master@{#434907}