Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_wpt.py

Issue 2518313003: Refactor WPT Export to ensure only one PR in flight at a time (Closed)
Patch Set: Add label 'Automated Chromium Export' to all new PRs Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_wpt.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_wpt.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_wpt.py
index d7655d452ce8cb2eb647695418df465122a6222c..2f4de66f685a55c62a3290260680b3fcc9486ce6 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_wpt.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_wpt.py
@@ -33,11 +33,15 @@ class ChromiumWPT(object):
'--', toplevel + '/' + CHROMIUM_WPT_DIR
]).splitlines()
- # TODO(jeffcarp): this is temporary until I solve
- # the import/export differentiation problem
+ # TODO(jeffcarp): allow this logic to be shared
def is_exportable(chromium_commit):
+ message = self.message(chromium_commit)
return (
- 'export' in self.message(chromium_commit)
+ 'NOEXPORT=true' not in message
+ and not message.startswith('Import ')
foolip 2016/11/29 11:12:20 Is the 'Import ' check still needed?
jeffcarp 2016/11/29 19:00:48 At the moment it's needed to ignore Import commits
+ # TODO(jeffcarp): change this to allow any commit with
+ # any non-expectation changes to be exportable
+ and not self._has_expectations(chromium_commit)
)
return filter(is_exportable, commits)

Powered by Google App Engine
This is Rietveld 408576698