Chromium Code Reviews| Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_wpt.py |
| diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_wpt.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_wpt.py |
| index d7655d452ce8cb2eb647695418df465122a6222c..2f4de66f685a55c62a3290260680b3fcc9486ce6 100644 |
| --- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_wpt.py |
| +++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_wpt.py |
| @@ -33,11 +33,15 @@ class ChromiumWPT(object): |
| '--', toplevel + '/' + CHROMIUM_WPT_DIR |
| ]).splitlines() |
| - # TODO(jeffcarp): this is temporary until I solve |
| - # the import/export differentiation problem |
| + # TODO(jeffcarp): allow this logic to be shared |
| def is_exportable(chromium_commit): |
| + message = self.message(chromium_commit) |
| return ( |
| - 'export' in self.message(chromium_commit) |
| + 'NOEXPORT=true' not in message |
| + and not message.startswith('Import ') |
|
foolip
2016/11/29 11:12:20
Is the 'Import ' check still needed?
jeffcarp
2016/11/29 19:00:48
At the moment it's needed to ignore Import commits
|
| + # TODO(jeffcarp): change this to allow any commit with |
| + # any non-expectation changes to be exportable |
| + and not self._has_expectations(chromium_commit) |
| ) |
| return filter(is_exportable, commits) |