Refactor WPT Export to ensure only one PR in flight at a time

third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_wpt.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """A utility class for interacting with the Chromium git tree
 for use cases relating to the Web Platform Tests.
 """
 
 CHROMIUM_WPT_DIR = 'third_party/WebKit/LayoutTests/imported/wpt/'
 
@@ skipping 15 matching lines @@
     def exportable_commits_since(self, commit):
         toplevel = self.host.executive.run_command([
             'git', 'rev-parse', '--show-toplevel'
         ]).strip()
 
         commits = self.host.executive.run_command([
             'git', 'rev-list', '{}..HEAD'.format(commit),
             '--', toplevel + '/' + CHROMIUM_WPT_DIR
         ]).splitlines()
 
-        # TODO(jeffcarp): this is temporary until I solve
-        #     the import/export differentiation problem
+        # TODO(jeffcarp): allow this logic to be shared
         def is_exportable(chromium_commit):
+            message = self.message(chromium_commit)
             return (
-                'export' in self.message(chromium_commit)
+                'NOEXPORT=true' not in message
+                and not message.startswith('Import ')

[foolip, 2016/11/29 11:12:20]

Is the 'Import ' check still needed?

[jeffcarp, 2016/11/29 19:00:48]

At the moment it's needed to ignore Import commits from before NOEXPORT=true was
merged. We can take this line out once we're past that point.

+                # TODO(jeffcarp): change this to allow any commit with
+                #   any non-expectation changes to be exportable
+                and not self._has_expectations(chromium_commit)
             )
 
         return filter(is_exportable, commits)
 
     def _has_expectations(self, chromium_commit):
         files = self.host.executive.run_command([
             'git', 'diff-tree', '--no-commit-id',
             '--name-only', '-r', chromium_commit
         ]).splitlines()
 
@@ skipping 26 matching lines @@
     @memoized
     def absolute_chromium_wpt_dir(self):
         finder = WebKitFinder(self.host.filesystem)
         return finder.path_from_webkit_base('LayoutTests', 'imported', 'wpt')
 
     # TODO(jeffcarp): this is duplicated in LocalWPT, maybe move into a GitRepo base class?
     def commits_behind_master(self, commit):
         return len(self.host.executive.run_command([
             'git', 'rev-list', '{}..origin/master'.format(commit)
         ]).splitlines())