Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2518283002: [ignition] Report NumberOrOddball feedback for relational comparisons. (Closed)

Created:
4 years ago by Benedikt Meurer
Modified:
4 years ago
Reviewers:
Jarin, rmcilroy
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ignition] Report NumberOrOddball feedback for relational comparisons. TurboFan can indeed comsume NumberOrOddball feedback for abstract relational comparisons, so we should just provide it from Ignition. Drive-by-fix: Add a DCHECK to protect against abstract/strict equality number comparison accidentially utilizing Oddball feedback. BUG=v8:5267, v8:5400 R=jarin@chromium.org Committed: https://crrev.com/6ce39edc868aeca2c11ef48b5ccd5044dfd5f63b Cr-Commit-Position: refs/heads/master@{#41166}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -11 lines) Patch
M src/compiler/simplified-lowering.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/globals.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/interpreter/interpreter.cc View 2 chunks +32 lines, -8 lines 0 comments Download
M src/type-feedback-vector-inl.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Benedikt Meurer
4 years ago (2016-11-22 07:49:13 UTC) #1
Benedikt Meurer
Jaro: PTAL Ross: FYI
4 years ago (2016-11-22 07:50:07 UTC) #4
Benedikt Meurer
Err, Ross: PTAL :-)
4 years ago (2016-11-22 08:01:57 UTC) #6
Jarin
lgtm.
4 years ago (2016-11-22 08:29:24 UTC) #7
rmcilroy
lgtm
4 years ago (2016-11-22 09:41:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518283002/1
4 years ago (2016-11-22 09:42:16 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-22 09:44:16 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-22 09:44:46 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ce39edc868aeca2c11ef48b5ccd5044dfd5f63b
Cr-Commit-Position: refs/heads/master@{#41166}

Powered by Google App Engine
This is Rietveld 408576698