[ignition] Report NumberOrOddball feedback for relational comparisons.

src/interpreter/interpreter.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/interpreter.h"
 
 #include <fstream>
 #include <memory>
 
 #include "src/ast/prettyprinter.h"
@@ skipping 1039 matching lines @@
       __ GotoUnless(__ WordEqual(lhs_map, __ HeapNumberMapConstant()),
                     &lhs_is_not_number);
 
       var_type_feedback.Bind(
           __ Int32Constant(CompareOperationFeedback::kNumber));
       __ Goto(&gather_rhs_type);
 
       __ Bind(&lhs_is_not_number);
       {
         Node* lhs_instance_type = __ LoadInstanceType(lhs);
-        Node* lhs_type =
+        if (Token::IsOrderedRelationalCompareOp(compare_op)) {
+          Label lhs_is_not_oddball(assembler);
+          __ GotoUnless(
+              __ Word32Equal(lhs_instance_type, __ Int32Constant(ODDBALL_TYPE)),
+              &lhs_is_not_oddball);
+
+          var_type_feedback.Bind(
+              __ Int32Constant(CompareOperationFeedback::kNumberOrOddball));
+          __ Goto(&gather_rhs_type);
+
+          __ Bind(&lhs_is_not_oddball);
+        }
+
+        var_type_feedback.Bind(
             __ Select(__ IsStringInstanceType(lhs_instance_type),
                       __ Int32Constant(CompareOperationFeedback::kString),
-                      __ Int32Constant(CompareOperationFeedback::kAny));
-
-        var_type_feedback.Bind(lhs_type);
+                      __ Int32Constant(CompareOperationFeedback::kAny)));
         __ Goto(&gather_rhs_type);
       }
     }
 
     __ Bind(&gather_rhs_type);
     {
       Label rhs_is_not_smi(assembler), rhs_is_not_number(assembler);
 
       __ GotoUnless(__ TaggedIsSmi(rhs), &rhs_is_not_smi);
 
       var_type_feedback.Bind(__ Word32Or(
           var_type_feedback.value(),
           __ Int32Constant(CompareOperationFeedback::kSignedSmall)));
       __ Goto(&update_feedback);
 
       __ Bind(&rhs_is_not_smi);
       {
         Node* rhs_map = __ LoadMap(rhs);
         __ GotoUnless(__ WordEqual(rhs_map, __ HeapNumberMapConstant()),
                       &rhs_is_not_number);
 
         var_type_feedback.Bind(
             __ Word32Or(var_type_feedback.value(),
                         __ Int32Constant(CompareOperationFeedback::kNumber)));
         __ Goto(&update_feedback);
 
         __ Bind(&rhs_is_not_number);
         {
           Node* rhs_instance_type = __ LoadInstanceType(rhs);
-          Node* rhs_type =
+          if (Token::IsOrderedRelationalCompareOp(compare_op)) {
+            Label rhs_is_not_oddball(assembler);
+            __ GotoUnless(__ Word32Equal(rhs_instance_type,
+                                         __ Int32Constant(ODDBALL_TYPE)),
+                          &rhs_is_not_oddball);
+
+            var_type_feedback.Bind(__ Word32Or(
+                var_type_feedback.value(),
+                __ Int32Constant(CompareOperationFeedback::kNumberOrOddball)));
+            __ Goto(&update_feedback);
+
+            __ Bind(&rhs_is_not_oddball);
+          }
+
+          var_type_feedback.Bind(__ Word32Or(
+              var_type_feedback.value(),
               __ Select(__ IsStringInstanceType(rhs_instance_type),
                         __ Int32Constant(CompareOperationFeedback::kString),
-                        __ Int32Constant(CompareOperationFeedback::kAny));
-          var_type_feedback.Bind(
-              __ Word32Or(var_type_feedback.value(), rhs_type));
+                        __ Int32Constant(CompareOperationFeedback::kAny))));
           __ Goto(&update_feedback);
         }
       }
     }
 
     __ Bind(&update_feedback);
     {
       __ UpdateFeedback(var_type_feedback.value(), type_feedback_vector,
                         slot_index);
       __ Goto(&do_compare);
@@ skipping 1655 matching lines @@
   __ StoreObjectField(generator, JSGeneratorObject::kContinuationOffset,
       __ SmiTag(new_state));
   __ SetAccumulator(old_state);
 
   __ Dispatch();
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8