chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js - Issue 2518233004: MD Settings: Move settings-advanced-page into settings-basic-page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js

Issue 2518233004: MD Settings: Move settings-advanced-page into settings-basic-page (Closed)

Patch Set: remove some redundancy Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/settings_main/settings_main.html ('K') | « chrome/test/data/webui/settings/advanced_page_browsertest.js ('k') | chrome/test/data/webui/settings/languages_page_browsertest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js

diff --git a/chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js b/chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js

index ba47f20682f81167e9a8be37314038a641102b64..63b6604acdeec504a2943db50168cbff3c7c9da7 100644

--- a/chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js

+++ b/chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js

@@ -60,9 +60,9 @@ TEST_F('SettingsBluetoothPageBrowserTest', 'MAYBE_Bluetooth', function() {

var self = this;

self.toggleAdvanced();

- var advanced = self.getPage('advanced');

- assertTrue(!!advanced);

- advanced.set('pageVisibility.bluetooth', true);

+ var page = self.getPage('basic');

+ assertTrue(!!page);

+ page.set('pageVisibility.bluetooth', true);

Polymer.dom.flush();

/** @type {!Array<!chrome.bluetooth.Device>} */ var fakeDevices_ = [

@@ -94,7 +94,7 @@ TEST_F('SettingsBluetoothPageBrowserTest', 'MAYBE_Bluetooth', function() {

suite('SettingsBluetoothPage', function() {

test('enable', function() {

assertFalse(self.bluetoothApi_.adapterState.powered);

- var bluetoothSection = self.getSection(advanced, 'bluetooth');

+ var bluetoothSection = self.getSection(page, 'bluetooth');

assertTrue(!!bluetoothSection);

var bluetooth =

bluetoothSection.querySelector('settings-bluetooth-page');

@@ -119,7 +119,7 @@ TEST_F('SettingsBluetoothPageBrowserTest', 'MAYBE_Bluetooth', function() {

});

test('device list', function() {

- var bluetoothSection = self.getSection(advanced, 'bluetooth');

+ var bluetoothSection = self.getSection(page, 'bluetooth');

var bluetooth =

bluetoothSection.querySelector('settings-bluetooth-page');

assertTrue(!!bluetooth);

@@ -153,7 +153,7 @@ TEST_F('SettingsBluetoothPageBrowserTest', 'MAYBE_Bluetooth', function() {

});

test('device dialog', function() {

- var bluetoothSection = self.getSection(advanced, 'bluetooth');

+ var bluetoothSection = self.getSection(page, 'bluetooth');

var bluetooth =

bluetoothSection.querySelector('settings-bluetooth-page');

assertTrue(!!bluetooth);