third_party/WebKit/LayoutTests/fast/table/large-col-span-crash.html - Issue 2518163002: [css-tables] Fix divide-by-zero resulting from 32-bit overflow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/table/large-col-span-crash.html

Issue 2518163002: [css-tables] Fix divide-by-zero resulting from 32-bit overflow (Closed)

Patch Set: with layout test Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/table/large-col-span-crash-expected.txt » ('j') | third_party/WebKit/Source/core/html/HTMLTableCellElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/table/large-col-span-crash.html

diff --git a/third_party/WebKit/LayoutTests/fast/table/large-col-span-crash.html b/third_party/WebKit/LayoutTests/fast/table/large-col-span-crash.html

new file mode 100644

index 0000000000000000000000000000000000000000..f7abfe1a40eb94d31422d2546ad1933240302aff

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/fast/table/large-col-span-crash.html

@@ -0,0 +1,19 @@

+<!doctype html>

mstensho (USE GERRIT) 2016/11/22 07:04:29 Could turn this into a testharness test, to get ri

dgrogan 2016/12/01 21:51:44 Done.

+<style>

+table {

+ width: 100px;

+ table-layout: fixed;

+ /* vv just to get a green square vv */

mstensho (USE GERRIT) 2016/11/22 07:04:29 Not so interesting, since this isn't a visual test

dgrogan 2016/12/01 21:51:44 Done.

+ height: 100px;

+ background: lime;

+</style>

+<table>

+<col span="4294967295">

+<col>

+</table>

+<script>

+if (window.testRunner)

+ testRunner.dumpAsText();

+</script>

+Pass if no crash