third_party/WebKit/LayoutTests/fast/table/large-col-span-crash.html - Issue 2518163002: [css-tables] Fix divide-by-zero resulting from 32-bit overflow

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/table/large-col-span-crash.html

Issue 2518163002: [css-tables] Fix divide-by-zero resulting from 32-bit overflow (Closed)

Patch Set: with layout test Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!doctype html>
	mstensho (USE GERRIT) 2016/11/22 07:04:29 Could turn this into a testharness test, to get ri Could turn this into a testharness test, to get rid of the expectation file. dgrogan 2016/12/01 21:51:44 Done. Show quoted text On 2016/11/22 07:04:29, mstensho wrote: > Could turn this into a testharness test, to get rid of the expectation file. Done.
	2 <style>

	3 table {

	4 width: 100px;

	5 table-layout: fixed;

	6 /* vv just to get a green square vv */
	mstensho (USE GERRIT) 2016/11/22 07:04:29 Not so interesting, since this isn't a visual test Not so interesting, since this isn't a visual test. But you could turn it into a testharness test and check the width and height, of course. :) dgrogan 2016/12/01 21:51:44 Done. Show quoted text On 2016/11/22 07:04:29, mstensho wrote: > Not so interesting, since this isn't a visual test. > > But you could turn it into a testharness test and check the width and height, of > course. :) Done.
	7 height: 100px;

	8 background: lime;

	9 }

	10 </style>

	11 <table>

	12 <col span="4294967295">

	13 <col>

	14 </table>

	15 <script>

	16 if (window.testRunner)

	17 testRunner.dumpAsText();

	18 </script>

	19 Pass if no crash

OLD	NEW