Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5671)

Unified Diff: chrome/browser/media_galleries/fileapi/picasa_data_provider.cc

Issue 2518053002: Always delete media galleries FilePathWatchers on the FILE thread. (Closed)
Patch Set: fix build error Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media_galleries/fileapi/picasa_data_provider.cc
diff --git a/chrome/browser/media_galleries/fileapi/picasa_data_provider.cc b/chrome/browser/media_galleries/fileapi/picasa_data_provider.cc
index 15275cc21e8b50c52d84ef79728c8021aee6ce7a..866789d0e5bb8afd6c1f3ab256ac02c9044072c1 100644
--- a/chrome/browser/media_galleries/fileapi/picasa_data_provider.cc
+++ b/chrome/browser/media_galleries/fileapi/picasa_data_provider.cc
@@ -11,7 +11,6 @@
#include "base/files/file_util.h"
#include "base/memory/ptr_util.h"
#include "base/strings/stringprintf.h"
-#include "chrome/browser/media_galleries/fileapi/file_path_watcher_util.h"
#include "chrome/browser/media_galleries/fileapi/media_file_system_backend.h"
#include "chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.h"
#include "chrome/browser/media_galleries/fileapi/safe_picasa_albums_indexer.h"
@@ -51,9 +50,7 @@ PicasaDataProvider::PicasaDataProvider(const base::FilePath& database_path)
weak_factory_.GetWeakPtr()));
}
-PicasaDataProvider::~PicasaDataProvider() {
- StopFilePathWatchOnMediaTaskRunner(std::move(temp_dir_watcher_));
-}
+PicasaDataProvider::~PicasaDataProvider() {}
void PicasaDataProvider::RefreshData(DataType needed_data,
const ReadyCallback& ready_callback) {
@@ -129,7 +126,7 @@ void PicasaDataProvider::InvalidateData() {
}
void PicasaDataProvider::OnTempDirWatchStarted(
- std::unique_ptr<base::FilePathWatcher> temp_dir_watcher) {
+ MediaFilePathWatcherUniquePtr temp_dir_watcher) {
MediaFileSystemBackend::AssertCurrentlyOnMediaSequence();
temp_dir_watcher_ = std::move(temp_dir_watcher);
}

Powered by Google App Engine
This is Rietveld 408576698