Handle push resubscribes with no sender info (avoids DCHECK)

Handle push resubscribes with no sender info (avoids DCHECK)

- Prior to this patch you would fail a DCHECK if you called
  PushManager.subscribe() with a sender id or key and then
  PushManager.subscribe() without a sender id or key.

- This fixes that and only allows resubscribing with no sender info
when the original subscribe was made with a gcm_sender_id.
Otherwise we throw an AbortError - no key provided.

BUG=659230
Review-Url: https://codereview.chromium.org/2469293002
Cr-Commit-Position: refs/heads/master@{#430601}
(cherry picked from commit d8e7aa32e6e15b1ce0cde3a6ccf878fb16ffc816)

Skipped cherry-picking tests
ResubscribeWithoutKeyAfterSubscribingFromDocumentWithNumber and
ResubscribeWithoutKeyAfterSubscribingFromWorkerWithNumber and their
helper functions documentSubscribePushWithNumericKey and
workerSubscribePushWithNumericKey since m55 predates
3f9e6105d28fbb930d90e38c23d07a9af9b53dbc which allowed passing numeric
values for applicationServerKey, so these are not applicable in m55.

Committed: https://chromium.googlesource.com/chromium/src/+/4d83ec675b64c4adc029fe4b753b617651dc9f16

[johnme, 2016-11-21 15:51:08]

Description was changed from

==========
Handle push resubscribes with no sender info (avoids DCHECK)

- Prior to this patch you would fail a DCHECK if you called
  PushManager.subscribe() with a sender id or key and then
  PushManager.subscribe() without a sender id or key.

- This fixes that and only allows resubscribing with no sender info
when the original subscribe was made with a gcm_sender_id.
Otherwise we throw an AbortError - no key provided.

BUG=659230

Review-Url: https://codereview.chromium.org/2469293002
Cr-Commit-Position: refs/heads/master@{#430601}
(cherry picked from commit d8e7aa32e6e15b1ce0cde3a6ccf878fb16ffc816)

Skipped cherry-picking tests
ResubscribeWithoutKeyAfterSubscribingFromDocumentWithNumber and
ResubscribeWithoutKeyAfterSubscribingFromWorkerWithNumber and their
helper functions documentSubscribePushWithNumericKey and
workerSubscribePushWithNumericKey since m55 predates
3f9e6105d28fbb930d90e38c23d07a9af9b53dbc which allowed passing numeric
values for applicationServerKey, so these are not applicable in m55.
==========

to

==========
Handle push resubscribes with no sender info (avoids DCHECK)

- Prior to this patch you would fail a DCHECK if you called
  PushManager.subscribe() with a sender id or key and then
  PushManager.subscribe() without a sender id or key.

- This fixes that and only allows resubscribing with no sender info
when the original subscribe was made with a gcm_sender_id.
Otherwise we throw an AbortError - no key provided.

BUG=659230

Review-Url: https://codereview.chromium.org/2469293002
Cr-Commit-Position: refs/heads/master@{#430601}
(cherry picked from commit d8e7aa32e6e15b1ce0cde3a6ccf878fb16ffc816)

Skipped cherry-picking tests
ResubscribeWithoutKeyAfterSubscribingFromDocumentWithNumber and
ResubscribeWithoutKeyAfterSubscribingFromWorkerWithNumber and their
helper functions documentSubscribePushWithNumericKey and
workerSubscribePushWithNumericKey since m55 predates
3f9e6105d28fbb930d90e38c23d07a9af9b53dbc which allowed passing numeric
values for applicationServerKey, so these are not applicable in m55.

Committed:
https://chromium.googlesource.com/chromium/src/+/4d83ec675b64c4adc029fe4b753b...
==========

[johnme, 2016-11-21 15:51:09]

Committed patchset #1 (id:1) manually as
4d83ec675b64c4adc029fe4b753b617651dc9f16.