Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5156)

Unified Diff: chrome/test/data/push_messaging/push_test.js

Issue 2518043002: Handle push resubscribes with no sender info (avoids DCHECK) (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/push_messaging/push_test.js
diff --git a/chrome/test/data/push_messaging/push_test.js b/chrome/test/data/push_messaging/push_test.js
index 4c7fb761c3b01e57f6f801471301a57652d8dc08..f0130ef9332982d61adef153fec850ee7548c0c1 100644
--- a/chrome/test/data/push_messaging/push_test.js
+++ b/chrome/test/data/push_messaging/push_test.js
@@ -139,7 +139,8 @@ function workerSubscribePush() {
function workerSubscribePushNoKey() {
// The worker will try to subscribe without providing a key. This should
- // succeed if the worker was previously subscribed and fail otherwise.
+ // succeed if the worker was previously subscribed with a numeric key
+ // and fail otherwise.
navigator.serviceWorker.controller.postMessage(
{command: 'workerSubscribeNoKey'});
}
« no previous file with comments | « chrome/browser/push_messaging/push_messaging_browsertest.cc ('k') | chrome/test/data/push_messaging/test_no_manifest.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698