Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2517983002: [DevTools] Properly handle cache-only requests when cache is disabled (Closed)

Created:
4 years, 1 month ago by jkarlin
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, devtools-reviews_chromium.org, jam, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, darin-cc_chromium.org, kinuko+cache_chromium.org, blink-reviews, apavlov+blink_chromium.org, blink-reviews-api_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

[DevTools] Properly handle cache-only requests when cache is disabled If a request is cache-only (e.g., back navigation to a POST) but "disable cache" is checked in dev-tools, then set the cache policy to both load only from cache and bypass the cache. This will result in the proper ERR_CACHE_MISS from the network stack. BUG=663728 Review-Url: https://codereview.chromium.org/2508473002 Cr-Commit-Position: refs/heads/master@{#432946} (cherry picked from commit c1331a41ffd5d4dce093398c03619eb8cc06f323) Committed: https://chromium.googlesource.com/chromium/src/+/8dd5e19d4d37ff197289108866705a65ce44a8e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -12 lines) Patch
M content/child/web_url_request_util.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/http/http_cache_transaction.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/http/http_cache_unittest.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 3 chunks +21 lines, -12 lines 0 comments Download
M third_party/WebKit/public/platform/WebCachePolicy.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jkarlin
4 years, 1 month ago (2016-11-21 13:09:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8dd5e19d4d37ff197289108866705a65ce44a8e6.

Powered by Google App Engine
This is Rietveld 408576698