[DevTools] Properly handle cache-only requests when cache is disabled

[DevTools] Properly handle cache-only requests when cache is disabled

If a request is cache-only (e.g., back navigation to a POST) but "disable
cache" is checked in dev-tools, then set the cache policy to both load only
from cache and bypass the cache. This will result in the proper ERR_CACHE_MISS
from the network stack.

BUG=663728
Committed: https://crrev.com/c1331a41ffd5d4dce093398c03619eb8cc06f323
Cr-Commit-Position: refs/heads/master@{#432946}

[jkarlin, 2016-11-15 18:14:27]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 18:15:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkarlin, 2016-11-15 18:17:19]

jkarlin@chromium.org changed reviewers:
+ dgozman@chromium.org, gavinp@chromium.org, jochen@chromium.org

[jkarlin, 2016-11-15 18:17:19]

dgozman@chromium.org: Please review changes in inspector/

gavinp@chromium.org: Please review changes in net/

jochen@chromium.org: Please review changes in content/child and
WebKit/public/platform

Thanks!

[jkarlin, 2016-11-15 18:17:58]

Description was changed from

==========
[DevTools] Properly handle cache-only requests when cache is disabled

If a request is cache-only (e.g., back navigation to a POST), then set the
cache policy to both load only from cache and bypass the cache. This will
result in the proper ERR_CACHE_MISS from the network stack.

BUG=663728
==========

to

==========
[DevTools] Properly handle cache-only requests when cache is disabled

If a request is cache-only (e.g., back navigation to a POST) but "disable cache"
is checked in dev-tools, then set the
cache policy to both load only from cache and bypass the cache. This will
result in the proper ERR_CACHE_MISS from the network stack.

BUG=663728
==========

[jkarlin, 2016-11-15 18:18:21]

Description was changed from

==========
[DevTools] Properly handle cache-only requests when cache is disabled

If a request is cache-only (e.g., back navigation to a POST) but "disable cache"
is checked in dev-tools, then set the
cache policy to both load only from cache and bypass the cache. This will
result in the proper ERR_CACHE_MISS from the network stack.

BUG=663728
==========

to

==========
[DevTools] Properly handle cache-only requests when cache is disabled

If a request is cache-only (e.g., back navigation to a POST) but "disable
cache" is checked in dev-tools, then set the cache policy to both load only
from cache and bypass the cache. This will result in the proper ERR_CACHE_MISS
from the network stack.

BUG=663728
==========

[jkarlin, 2016-11-15 18:20:33]

jkarlin@chromium.org changed reviewers:
- jochen@chromium.org

[jkarlin, 2016-11-15 18:22:09]

jkarlin@chromium.org changed reviewers:
+ jochen@chromium.org

[dgozman, 2016-11-15 18:29:13]

https://codereview.chromium.org/2508473002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp (right):

https://codereview.chromium.org/2508473002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp:631: if
((request.getCachePolicy() == WebCachePolicy::ReturnCacheDataDontLoad ||
What about ReturnCacheDataIfValid?

[jkarlin, 2016-11-15 18:38:17]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 18:38:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkarlin, 2016-11-15 18:39:15]

PTAL

https://codereview.chromium.org/2508473002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp (right):

https://codereview.chromium.org/2508473002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp:631: if
((request.getCachePolicy() == WebCachePolicy::ReturnCacheDataDontLoad ||
On 2016/11/15 18:29:13, dgozman wrote:
> What about ReturnCacheDataIfValid?

Thanks! Added a function with a switch to make sure that doesn't happen again.

[dgozman, 2016-11-15 19:54:03]

inspector lgtm, but I'm not an expert to judge the new WebCachePolicy flag.

https://codereview.chromium.org/2508473002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp (right):

https://codereview.chromium.org/2508473002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp:119: bool
LoadsFromCacheOnly(const ResourceRequest& request) {
Either static or anonymous namespace please.

[commit-bot: I haz the power, 2016-11-15 20:29:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 20:29:31]

Dry run: This issue passed the CQ dry run.

[jkarlin, 2016-11-15 21:27:21]

Thanks!

gavinp@ jochen@ PTAL

https://codereview.chromium.org/2508473002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp (right):

https://codereview.chromium.org/2508473002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp:119: bool
LoadsFromCacheOnly(const ResourceRequest& request) {
On 2016/11/15 19:54:02, dgozman wrote:
> Either static or anonymous namespace please.

It's in the anonymous namespace already.

[jochen (gone - plz use gerrit), 2016-11-17 01:59:33]

lgtm

[jkarlin, 2016-11-17 15:54:30]

jkarlin@chromium.org changed reviewers:
+ juliatuttle@chromium.org

[jkarlin, 2016-11-17 15:54:50]

Julia: PTAL at net/, thanks!

[Julia Tuttle, 2016-11-17 16:15:13]

net/ lgtm.

[jkarlin, 2016-11-17 16:15:39]

Thanks!

[jkarlin, 2016-11-17 16:16:50]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2016-11-17 16:17:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 17:42:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 17:42:32]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jkarlin, 2016-11-17 18:31:22]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2016-11-17 18:33:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 20:19:35]

Description was changed from

==========
[DevTools] Properly handle cache-only requests when cache is disabled

If a request is cache-only (e.g., back navigation to a POST) but "disable
cache" is checked in dev-tools, then set the cache policy to both load only
from cache and bypass the cache. This will result in the proper ERR_CACHE_MISS
from the network stack.

BUG=663728
==========

to

==========
[DevTools] Properly handle cache-only requests when cache is disabled

If a request is cache-only (e.g., back navigation to a POST) but "disable
cache" is checked in dev-tools, then set the cache policy to both load only
from cache and bypass the cache. This will result in the proper ERR_CACHE_MISS
from the network stack.

BUG=663728
==========

[commit-bot: I haz the power, 2016-11-17 20:19:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-17 20:29:28]

Description was changed from

==========
[DevTools] Properly handle cache-only requests when cache is disabled

If a request is cache-only (e.g., back navigation to a POST) but "disable
cache" is checked in dev-tools, then set the cache policy to both load only
from cache and bypass the cache. This will result in the proper ERR_CACHE_MISS
from the network stack.

BUG=663728
==========

to

==========
[DevTools] Properly handle cache-only requests when cache is disabled

If a request is cache-only (e.g., back navigation to a POST) but "disable
cache" is checked in dev-tools, then set the cache policy to both load only
from cache and bypass the cache. This will result in the proper ERR_CACHE_MISS
from the network stack.

BUG=663728

Committed: https://crrev.com/c1331a41ffd5d4dce093398c03619eb8cc06f323
Cr-Commit-Position: refs/heads/master@{#432946}
==========

[commit-bot: I haz the power, 2016-11-17 20:29:29]

Patchset 3 (id:??) landed as
https://crrev.com/c1331a41ffd5d4dce093398c03619eb8cc06f323
Cr-Commit-Position: refs/heads/master@{#432946}