Move enable_webrtc to a buildflag header.

Move enable_webrtc to a buildflag header.

Removes enable_webrtc from build/config/features.gni and puts it in
media/media_options.gni.

Converts the ENABLE_WEBRTC from a define set globally to being set in the
media_features.h generated buildflag header.

R=sky@chromium.org
TBR=nasko@chromium.org (*_messages.h)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://chromium.googlesource.com/chromium/src/+/0748bf41870093364ae96165f6fa1062c9f19ae0

[brettw, 2016-11-21 20:42:17]

Description was changed from

==========
Move enable_webrtc to a buildflag header.

Removes enable_webrtc from build/config/features.gni and puts it in
media/media_options.gni.

Converts the ENABLE_WEBRTC from a define set globally to being set in the
media_features.h generated buildflag header.
==========

to

==========
Move enable_webrtc to a buildflag header.

Removes enable_webrtc from build/config/features.gni and puts it in
media/media_options.gni.

Converts the ENABLE_WEBRTC from a define set globally to being set in the
media_features.h generated buildflag header.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[brettw, 2016-11-21 20:42:19]

Description was changed from

==========
Move enable_webrtc to a buildflag header.

Removes enable_webrtc from build/config/features.gni and puts it in
media/media_options.gni.

Converts the ENABLE_WEBRTC from a define set globally to being set in the
media_features.h generated buildflag header.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move enable_webrtc to a buildflag header.

Removes enable_webrtc from build/config/features.gni and puts it in
media/media_options.gni.

Converts the ENABLE_WEBRTC from a define set globally to being set in the
media_features.h generated buildflag header.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[brettw, 2016-11-21 21:05:12]

brettw@chromium.org changed reviewers:
+ sky@chromium.org

[brettw, 2016-11-21 21:05:13]

The source files are basically search-and-replace. You might want to just review
the BUILD files (easy).

[brettw, 2016-11-21 21:05:20]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 21:06:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-11-21 22:36:05]

LGTM assuming you don't need a media include in all the files. If you do, I
think there are a handful that you missed (<5ish).

https://codereview.chromium.org/2517953003/diff/1/content/browser/gpu/gpu_dat...
File content/browser/gpu/gpu_data_manager_impl_private.cc (right):

https://codereview.chromium.org/2517953003/diff/1/content/browser/gpu/gpu_dat...
content/browser/gpu/gpu_data_manager_impl_private.cc:692: #if
BUILDFLAG(ENABLE_WEBRTC)
How come you don't include media/media_features in all files that use
ENABLE_WEBRTC?

[commit-bot: I haz the power, 2016-11-21 23:03:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 23:03:30]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[brettw, 2016-11-21 23:18:45]

https://codereview.chromium.org/2517953003/diff/1/content/browser/gpu/gpu_dat...
File content/browser/gpu/gpu_data_manager_impl_private.cc (right):

https://codereview.chromium.org/2517953003/diff/1/content/browser/gpu/gpu_dat...
content/browser/gpu/gpu_data_manager_impl_private.cc:692: #if
BUILDFLAG(ENABLE_WEBRTC)
I missed this one (it's included in several "popular" headers which is why I
guess it works). Most of the ones that you don't see the addition in already
have it.

[brettw, 2016-11-22 15:39:56]

Fix

[brettw, 2016-11-22 15:39:57]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-11-22 15:39:58]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2517953003/#ps20001
(title: "Fix")

[commit-bot: I haz the power, 2016-11-22 15:40:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 15:49:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 15:49:05]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2016-11-22 15:59:15]

Description was changed from

==========
Move enable_webrtc to a buildflag header.

Removes enable_webrtc from build/config/features.gni and puts it in
media/media_options.gni.

Converts the ENABLE_WEBRTC from a define set globally to being set in the
media_features.h generated buildflag header.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Move enable_webrtc to a buildflag header.

Removes enable_webrtc from build/config/features.gni and puts it in
media/media_options.gni.

Converts the ENABLE_WEBRTC from a define set globally to being set in the
media_features.h generated buildflag header.

TBR=nasko@chromium.org (*_messages.h)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[brettw, 2016-11-22 15:59:15]

brettw@chromium.org changed reviewers:
+ nasko@chromium.org

[brettw, 2016-11-22 15:59:42]

TBR=nasko for mechanical changes in *_messages.h files.

[brettw, 2016-11-22 16:14:50]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-11-22 16:15:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 17:40:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 17:40:56]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2016-11-22 18:07:40]

Description was changed from

==========
Move enable_webrtc to a buildflag header.

Removes enable_webrtc from build/config/features.gni and puts it in
media/media_options.gni.

Converts the ENABLE_WEBRTC from a define set globally to being set in the
media_features.h generated buildflag header.

TBR=nasko@chromium.org (*_messages.h)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Move enable_webrtc to a buildflag header.

Removes enable_webrtc from build/config/features.gni and puts it in
media/media_options.gni.

Converts the ENABLE_WEBRTC from a define set globally to being set in the
media_features.h generated buildflag header.

R=sky@chromium.org
TBR=nasko@chromium.org (*_messages.h)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/0748bf41870093364ae96165f6fa1062c9f19ae0
Cr-Commit-Position: refs/heads/master@{#433912}
==========

[commit-bot: I haz the power, 2016-11-22 18:07:42]

Patchset 2 (id:??) landed as
https://crrev.com/0748bf41870093364ae96165f6fa1062c9f19ae0
Cr-Commit-Position: refs/heads/master@{#433912}

[brettw, 2016-11-22 18:09:00]

Description was changed from

==========
Move enable_webrtc to a buildflag header.

Removes enable_webrtc from build/config/features.gni and puts it in
media/media_options.gni.

Converts the ENABLE_WEBRTC from a define set globally to being set in the
media_features.h generated buildflag header.

R=sky@chromium.org
TBR=nasko@chromium.org (*_messages.h)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/0748bf41870093364ae96165f6fa1062c9f19ae0
Cr-Commit-Position: refs/heads/master@{#433912}
==========

to

==========
Move enable_webrtc to a buildflag header.

Removes enable_webrtc from build/config/features.gni and puts it in
media/media_options.gni.

Converts the ENABLE_WEBRTC from a define set globally to being set in the
media_features.h generated buildflag header.

R=sky@chromium.org
TBR=nasko@chromium.org (*_messages.h)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed:
https://chromium.googlesource.com/chromium/src/+/0748bf41870093364ae96165f6fa...
==========

[brettw, 2016-11-22 18:09:02]

Committed patchset #2 (id:20001) manually as
0748bf41870093364ae96165f6fa1062c9f19ae0 (presubmit successful).

[nasko, 2016-11-23 01:39:18]

content/common/gpu_host_messages.h LGTM