Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1755)

Unified Diff: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h

Issue 2517953003: Move enable_webrtc to a buildflag header. (Closed)
Patch Set: Fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h
diff --git a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h
index 8fdf3509234164f5d54b03d570bb0b944284d48d..213b75c543432d8476a3019e3c562e717cc0bf60 100644
--- a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h
+++ b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h
@@ -8,12 +8,14 @@
#include <string>
#include "chrome/browser/extensions/chrome_extension_function.h"
-#if defined(ENABLE_WEBRTC)
+#include "chrome/common/extensions/api/webrtc_logging_private.h"
+#include "media/media_features.h"
+
+#if BUILDFLAG(ENABLE_WEBRTC)
#include "chrome/browser/media/audio_debug_recordings_handler.h"
#include "chrome/browser/media/webrtc/webrtc_event_log_handler.h"
#include "chrome/browser/media/webrtc/webrtc_logging_handler_host.h"
#endif
-#include "chrome/common/extensions/api/webrtc_logging_private.h"
namespace content {
@@ -27,7 +29,7 @@ class WebrtcLoggingPrivateFunction : public ChromeAsyncExtensionFunction {
protected:
~WebrtcLoggingPrivateFunction() override {}
-#if defined(ENABLE_WEBRTC)
+#if BUILDFLAG(ENABLE_WEBRTC)
// Returns the RenderProcessHost associated with the given |request|
// authorized by the |security_origin|. Returns null if unauthorized or
// the RPH does not exist.
@@ -46,7 +48,7 @@ class WebrtcLoggingPrivateFunctionWithGenericCallback
protected:
~WebrtcLoggingPrivateFunctionWithGenericCallback() override {}
-#if defined(ENABLE_WEBRTC)
+#if BUILDFLAG(ENABLE_WEBRTC)
// Finds the appropriate logging handler for performing the task and prepares
// a generic callback object for when the task is completed.
// If the logging handler can't be found for the given request+origin, the
@@ -66,7 +68,7 @@ class WebrtcLoggingPrivateFunctionWithUploadCallback
protected:
~WebrtcLoggingPrivateFunctionWithUploadCallback() override {}
-#if defined(ENABLE_WEBRTC)
+#if BUILDFLAG(ENABLE_WEBRTC)
// Must be called on UI thread.
void FireCallback(bool success, const std::string& report_id,
const std::string& error_message);
@@ -78,7 +80,7 @@ class WebrtcLoggingPrivateFunctionWithRecordingDoneCallback
protected:
~WebrtcLoggingPrivateFunctionWithRecordingDoneCallback() override {}
-#if defined(ENABLE_WEBRTC)
+#if BUILDFLAG(ENABLE_WEBRTC)
// Must be called on UI thread.
void FireErrorCallback(const std::string& error_message);
void FireCallback(const std::string& prefix_path,

Powered by Google App Engine
This is Rietveld 408576698