Source/core/rendering/RenderBox.h - Issue 251783004: Don't paint below image's baseline unless it is selected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBox.h

Issue 251783004: Don't paint below image's baseline unless it is selected. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/images/do-not-paint-below-image-baseline.html ('K') | « LayoutTests/virtual/deferred/fast/images/do-not-paint-below-image-baseline-expected.txt ('k') | Source/core/rendering/RenderBox.cpp » ('j') | Source/core/rendering/RenderReplaced.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBox.h

diff --git a/Source/core/rendering/RenderBox.h b/Source/core/rendering/RenderBox.h

index 3c834aa590e328ed30a9e575ec9a9c2a7879168b..93e9fc5e96f36eece21133e0fd31c158f839050d 100644

--- a/Source/core/rendering/RenderBox.h

+++ b/Source/core/rendering/RenderBox.h

@@ -662,6 +662,7 @@ protected:

void updateIntrinsicContentLogicalHeight(LayoutUnit intrinsicContentLogicalHeight) const { m_intrinsicContentLogicalHeight = intrinsicContentLogicalHeight; }

+ virtual LayoutRect overflowRectForRepaint() const { return visualOverflowRect(); }

private:

void updateShapeOutsideInfoAfterStyleChange(const RenderStyle&, const RenderStyle* oldStyle);

void updateGridPositionAfterStyleChange(const RenderStyle*);