Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1518)

Unified Diff: Source/core/rendering/RenderReplaced.h

Issue 251783004: Don't paint below image's baseline unless it is selected. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderReplaced.h
diff --git a/Source/core/rendering/RenderReplaced.h b/Source/core/rendering/RenderReplaced.h
index 030e2c870d2ae0a93b9cf4636461233418966787..dcd863edb192837a07b9abcb2937304abceeacbe 100644
--- a/Source/core/rendering/RenderReplaced.h
+++ b/Source/core/rendering/RenderReplaced.h
@@ -69,6 +69,8 @@ protected:
LayoutRect localSelectionRect(bool checkWhetherSelected = true) const; // This is in local coordinates, but it's a physical rect (so the top left corner is physical top left).
virtual RenderBox* embeddedContentBox() const { return 0; }
+ virtual LayoutRect overflowRectForRepaint() const OVERRIDE FINAL { return isSelected() ? localSelectionRect() : visualOverflowRect(); }
Julien - ping for review 2014/05/02 00:23:35 I wonder if it would make sense for the visualOver
rhogan 2014/05/02 15:36:27 That's what we do currently for replaced objects -
+
private:
virtual const char* renderName() const OVERRIDE { return "RenderReplaced"; }
@@ -77,8 +79,6 @@ private:
virtual void computePreferredLogicalWidths() OVERRIDE FINAL;
virtual void paintReplaced(PaintInfo&, const LayoutPoint&) { }
- virtual LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObject* repaintContainer) const OVERRIDE;
-
virtual PositionWithAffinity positionForPoint(const LayoutPoint&) OVERRIDE FINAL;
virtual bool canBeSelectionLeaf() const OVERRIDE { return true; }

Powered by Google App Engine
This is Rietveld 408576698