Don't include usage counters, etc in snapshots with code. If we already have code, eagerly recompil…

Don't include usage counters, etc in snapshots with code. If we already have code, eagerly recompiling in unlikely to have new type feedback.
Print snapshot sizes when generating an AOT snapshot from gen_snapshot (e.g., Flutter).
Remove some unnecessary symbols.
Use named constants for exit codes.
Use Log::PrintErr instead of fprintf(stderr) so we see error messages in adb logcat.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/5ee71cae9d22cd4e48a3fbd31508b6e5a560caa0

[rmacnak, 2016-11-18 22:31:29]

rmacnak@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-11-22 05:23:53]

lgtm

https://codereview.chromium.org/2517683002/diff/20001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/2517683002/diff/20001/runtime/bin/main.cc#new...
runtime/bin/main.cc:136: 
Why did you remove this fflush(stderr); ?

[rmacnak, 2016-11-22 17:58:45]

https://codereview.chromium.org/2517683002/diff/20001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/2517683002/diff/20001/runtime/bin/main.cc#new...
runtime/bin/main.cc:136: 
On 2016/11/22 05:23:53, siva wrote:
> Why did you remove this fflush(stderr); ?
> 

VPrintErr already does a flush

[rmacnak, 2016-11-22 17:59:10]

Description was changed from

==========
Don't include usage counters, etc in snapshots with code. If we already have
code, eagerly recompiling in unlikely to have new type feedback.
Print snapshot sizes when generating an AOT snapshot from gen_snapshot (e.g.,
Flutter).
Remove some unnecessary symbols.
Use named constants for exit codes.
Use Log::PrintErr instead of fprintf(stderr) so we see error messages in adb
logcat.
==========

to

==========
Don't include usage counters, etc in snapshots with code. If we already have
code, eagerly recompiling in unlikely to have new type feedback.
Print snapshot sizes when generating an AOT snapshot from gen_snapshot (e.g.,
Flutter).
Remove some unnecessary symbols.
Use named constants for exit codes.
Use Log::PrintErr instead of fprintf(stderr) so we see error messages in adb
logcat.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5ee71cae9d22cd4e48a3fbd31508b6e5a560caa0
==========

[rmacnak, 2016-11-22 17:59:11]

Committed patchset #3 (id:40001) manually as
5ee71cae9d22cd4e48a3fbd31508b6e5a560caa0 (presubmit successful).