Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: runtime/bin/main.cc

Issue 2517683002: Don't include usage counters, etc in snapshots with code. If we already have code, eagerly recompil… (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/log_linux.cc ('k') | runtime/vm/clustered_snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/main.cc
diff --git a/runtime/bin/main.cc b/runtime/bin/main.cc
index 13737c156018230ec1d2e28d6ef2522aeb9c953c..fc9af70c529d42a6888ad15a7cb52c77f00b2731 100644
--- a/runtime/bin/main.cc
+++ b/runtime/bin/main.cc
@@ -133,7 +133,6 @@ static void ErrorExit(int exit_code, const char* format, ...) {
va_start(arguments, format);
Log::VPrintErr(format, arguments);
va_end(arguments);
- fflush(stderr);
Dart_ExitScope();
Dart_ShutdownIsolate();
@@ -1598,9 +1597,8 @@ bool RunMainIsolate(const char* script_name, CommandLineOptions* dart_options) {
// Load the embedder's portion of the VM service's Dart code so it will
// be included in the app snapshot.
if (!VmService::LoadForGenPrecompiled()) {
- fprintf(stderr, "VM service loading failed: %s\n",
- VmService::GetErrorMessage());
- fflush(stderr);
+ Log::PrintErr("VM service loading failed: %s\n",
+ VmService::GetErrorMessage());
exit(kErrorExitCode);
}
}
@@ -1848,8 +1846,7 @@ void main(int argc, char** argv) {
if (!DartUtils::SetOriginalWorkingDirectory()) {
OSError err;
- fprintf(stderr, "Error determining current directory: %s\n", err.message());
- fflush(stderr);
+ Log::PrintErr("Error determining current directory: %s\n", err.message());
Platform::Exit(kErrorExitCode);
}
@@ -1910,8 +1907,7 @@ void main(int argc, char** argv) {
char* error = Dart_Initialize(&init_params);
if (error != NULL) {
EventHandler::Stop();
- fprintf(stderr, "VM initialization failed: %s\n", error);
- fflush(stderr);
+ Log::PrintErr("VM initialization failed: %s\n", error);
free(error);
Platform::Exit(kErrorExitCode);
}
« no previous file with comments | « runtime/bin/log_linux.cc ('k') | runtime/vm/clustered_snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698